-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Would it support for private repo? #103
Comments
@xihajun The code you deploy can be private and you could have a separate repo for the Can you explain your use case? It shouldn't matter the repo is public as any github issues are publicly being displayed on the status page anyway |
@tadhglewis Thanks for your reply! What is the different between the If it is for internal status usage, it would be good to have it support for private repo and other people won't know the link for this status anyway. I found we can bypass it given the GitHub token, but should there be a better way? |
@xihajun interesting. definitely will consider this as I'm currently overhauling and adding support for so called "custom Providers" which allow you to swap out the underlying data source the frontend uses. To go into a bit more detail;
If you have sensitive data in a repo and want it private, it's recommended to create a fresh repo for the database (REACT_APP_REPOSITORY) which only contains the GitHub Issues. Technically speaking, there can be two repos: one with the source code (e.g. https://github.com/tadhglewis/issue-status) and a separate one for the db/GitHub Issues.
Is the link publicly accessible? If so I'd say just make a public repo... To be honest, this project isn't currently well designed for private(internal) use cases as everything is unauthenticated.
Be wary: in the current state, this project is entirely frontend so any tokens you include will be leaked to the frontend |
@tadhglewis Thanks for the details!
Thanks for pointing out! I am not too familiar with front end, but I will try to avoid that when using in production with internal access or add a passwd and restrict by ip address, etc. Currently I am testing the functionality and it works nicely. Thanks for open source the lovely project! |
Thanks for the lovely tool, I wonder would it support for those private repos?
The text was updated successfully, but these errors were encountered: