Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert overwrites the entire file if an otp entry already exists #163

Closed
u91o opened this issue May 13, 2022 · 1 comment
Closed

insert overwrites the entire file if an otp entry already exists #163

u91o opened this issue May 13, 2022 · 1 comment

Comments

@u91o
Copy link

u91o commented May 13, 2022

1
2
3
otpauth://totp/OLD
a
b
c

With the example pass file above, the current behavior of pass otp insert overwrites the entire file to be become the following:

otpauth://totp/NEW

Is this the intended behavior? If so, I think a more explicit warning is warranted considering the risk here. If not, I would like to work on a PR to resolve this.

@u91o u91o closed this as completed May 19, 2022
@ghost
Copy link

ghost commented Apr 21, 2023

@u91o
@tadfisher

Ehm.. why was this closed, it is still an issue.

I hate this behaviour of pass-otp and in company with #169 it makes
pass otp add foobar
totally useless, because it is easier to just run
pass edit foobar
and add the
otpauth:// URI
manually.

At the moment I use pass-otp only to display the actual otp and nothing more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant