Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example and document for Dialog component #164

Open
SimeonC opened this issue Mar 6, 2023 · 0 comments
Open

Add example and document for Dialog component #164

SimeonC opened this issue Mar 6, 2023 · 0 comments

Comments

@SimeonC
Copy link
Contributor

SimeonC commented Mar 6, 2023

TK3 won't have a dedicated Dialog component like TK2 did. We need to add documentation for this and an example like here.

Reasoning for not creating a dedicated component this time around;

  • Often all we need is what's provided in Radix-UI Dialog
  • The new styling for a TK3 Dialog is very, very short and is trivial to implement with existing exported CSS properties and the Figma guidelines
  • Often we found the need to work around the options, or add more for times when we needed no internal padding or similar. This lead to a fairly unweildly API with far too many options to be useful. We want to offload this complexity to the implementation so each project is not restricted by TK rules and can implement as needed.

Below is for reference - look to figma or the live documentation for most up to date

Desktop Style Guidelines

CleanShot 2023-03-06 at 11 20 14@2x

Mobile Style Guidelines

CleanShot 2023-03-06 at 11 20 04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant