local build now broken...

Author: mbt1

Build/CommonFunctionsAndMethods.psm1

@@ -116,48 +116,6 @@ $dddafter-$dddbefore
     }
 }
 
-Function Get-SqlConnectionString
-{
-  [CmdletBinding()]
-  param(
-    [Parameter(Mandatory=$true)][ValidateNotNullOrEmpty()][string] $ServerName,
-    [Parameter(Mandatory=$true)][ValidateNotNullOrEmpty()][string] $Login,
-    [Parameter(Mandatory=$true)][ValidateNotNullOrEmpty()][string] $DatabaseName
-  );
-
-  $ServerNameTrimmed = $ServerName.Trim();
-  $LoginTrimmed = $Login.Trim();
-
-  <# 
-    ☹️
-    This is so questionable, but it looks like sqlpackage cannot handle valid connection strings that use a valid server alias.
-    The following snippet is meant to spelunk through the registry and extract the actual server from the alias.
-    ☹️
-  #>
-  $resolvedServerName = $ServerNameTrimmed;
-  $serverAlias = Get-Item -Path HKLM:\SOFTWARE\Microsoft\MSSQLServer\Client\ConnectTo -ErrorAction SilentlyContinue;
-  if ($null -ne $serverAlias -And $serverAlias.GetValueNames() -contains $ServerNameTrimmed) {
-      $aliasValue = $serverAlias.GetValue($ServerNameTrimmed)
-      if ($aliasValue -match "DBMSSOCN[,](.*)"){
-          $resolvedServerName = $Matches[1];
-      }
-  }
-  
-  <# When using Windows Authentication, you must use "Integrated Security=SSPI" in the SqlConnectionString. Else use "User ID=<username>;Password=<password>;" #>
-  if ($LoginTrimmed -match '((.*[-][uU])|(.*[-][pP]))+.*'){
-      $AuthenticationString = $LoginTrimmed -replace '^((\s*[-][uU]\s+(?<user>\S+)\s*)|(\s*[-][pP]\s+)((?<quote>[''"])(?<password>.*?)\k<quote>|(?<password>\S+))\s*)+$', 'User Id=${user};Password="${password}"'  
-  }
-  elseif ($LoginTrimmed -eq "-E"){
-      $AuthenticationString = "Integrated Security=SSPI;";
-  }
-  else{
-      throw $LoginTrimmed + " is not supported here."
-  }
-
-  $SqlConnectionString = "Data Source="+$resolvedServerName+";"+$AuthenticationString+";Connect Timeout=60;Initial Catalog="+$DatabaseName+";TrustServerCertificate=true;";
-  $SqlConnectionString;
-}
-
 function Get-TempFileForQuery {
   [CmdletBinding()]
   [OutputType([string])]

Build/LocalBuild.ps1

@@ -1,5 +1,3 @@
-using module "./CommonFunctionsAndMethods.psm1";
-
 param(
     [Parameter(Mandatory=$false)][ValidateNotNullOrEmpty()][string] $ServerName = 'localhost,1433',
     [Parameter(Mandatory=$true, ParameterSetName = 'UserPass')][ValidateNotNullOrEmpty()][string] $UserName = "sa" ,
@@ -14,7 +12,14 @@ param(
 $PSDefaultParameterValues = $PSDefaultParameterValues.clone()
 $PSDefaultParameterValues += @{'*:ErrorAction' = 'Stop'}
 
-Get-Module -Name CommonFunctionsAndMethods | Select-Object Name, Path, Version
+Write-Host "Starting execution of LocalBuild.ps1"
+$__=$__ #quiesce warnings
+$invocationDir = $PSScriptRoot
+Push-Location -Path $invocationDir
+$cfam = (Join-Path $invocationDir "CommonFunctionsAndMethods.psm1" | Resolve-Path)
+Write-Host "Attempting to load module from: $cfam"
+Import-Module "$cfam" -Force -Verbose
+. (Join-Path $invocationDir 'SQLServerConnection.ps1');
 
 function CleanTemp {
     param (

Build/SQLServerConnection.ps1

@@ -6,7 +6,7 @@ if (-not ([System.Management.Automation.PSTypeName]'SqlServerConnection').Type)
       hidden [System.Security.SecureString]$Password
       hidden [bool]$TrustedConnection
       hidden [string]$ApplicationName
-      hidden [string]$BaseConnectionString = "Connect Timeout=60;TrustServerCertificate=true;"
+      hidden [string]$BaseConnectionString = "Connect Timeout=60;Encrypt=false;TrustServerCertificate=true;"
 
       SqlServerConnection([string]$ServerName, [string]$UserName, [System.Security.SecureString]$Password,[string]$ApplicationName) {
         $this.ServerName = $ServerName.Trim()

CI/Azure-DevOps/CreateSQLVM_azcli.ps1

@@ -19,7 +19,7 @@ Param(
     [Parameter(Mandatory=$true)][ValidateNotNullOrEmpty()][string] $VMPriority
 );
 
-Write-Host "Starting execution of CreateSQLContainer.ps1"
+Write-Host "Starting execution of CreateSQLVM_azcli.ps1"
 $__=$__ #quiesce warnings
 $invocationDir = $PSScriptRoot
 Push-Location -Path $invocationDir