Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random from favorites but different from last #608

Open
xgdgsc opened this issue Sep 3, 2024 · 2 comments
Open

Random from favorites but different from last #608

xgdgsc opened this issue Sep 3, 2024 · 2 comments
Labels
bug Something isn't working priority-medium

Comments

@xgdgsc
Copy link

xgdgsc commented Sep 3, 2024

Random from favorites but different from last. Now it could be the same as last theme.

@t1m0thyj t1m0thyj added bug Something isn't working priority-medium labels Oct 12, 2024
@t1m0thyj
Copy link
Owner

Related to #510 - WinDD stores "shuffleHistory" in settings.json to keep track of the last theme ID picked, so it should already be picking a theme different from the last one.

Next time this happens, please upload your settings.json file (with location info redacted) that includes the "shuffleHistory" and provide the name of the theme being shown twice.

@xgdgsc
Copy link
Author

xgdgsc commented Oct 14, 2024

Not a c# expert here. Is

if (themeChoices.Length > 0)
true when the history is not long? I guess I only saw this when I just started using this and not seeing this issue after days of using when the history list already contains all favorites?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-medium
Projects
None yet
Development

No branches or pull requests

2 participants