Setup CI

[shardros]

AS A shepherd developer
I WANT to not be allowed to commit broken code to master
SO THAT the user expierence is bug free
DONE IS:

• CI is setup running all of the tests in /test
• It is not possible to commit to master with failing tests
• Linting etc should also be run, nothing too aggressive

NOTES:

• @shardros's personal vote for Github Actions + PyTest + Pipenv

[Minion3665]

Could we use something like black in leu of/in addition to a linter? That way we know the code will be entirely consistent while also not having to worry about many points of a stricter code style such as pycodestyle

[shardros]

There are many benifit to linters which autoformaters cannot solve, such as checking for methods which are too long, too many args.

Not to mention all of the error checking they do.

Personally I dislike black. Its very opionated on things which do matter. Sometimes you want to format arrays in a particular way because it's clearer to read. I trust the judgement of the people working on this project enough to trust that they will be able to format a document clearer than black.

I would suggest autopep8 instead. It only enforces PEP8 which I think is a good set of rules which are always true for cleaner code.

Black makes decisions about things which are sometimes true and that's worse than useless when it chooses wrong.

I sometimes feel like it chooses the worst possible style on purpose as a test of loyalty.

I know about fmt: on/off but that is just more noise and even less clean code than there was to begin with.

These are just my opions and I can be convinced otherwise.

[Minion3665]

There are many benifit to linters which autoformaters cannot solve, such as checking for methods which are too long, too many args.

Not to mention all of the error checking they do.

Personally I dislike black. Its very opionated on things which do matter. Sometimes you want to format arrays in a particular way because it's clearer to read. I trust the judgement of the people working on this project enough to trust that they will be able to format a document clearer than black.

I would suggest autopep8 instead. It only enforces PEP8 which I think is a good set of rules which are always true for cleaner code.

Black makes decisions about things which are sometimes true and that's worse than useless when it chooses wrong.

I sometimes feel like it chooses the worst possible style on purpose as a test of loyalty.

I know about fmt: on/off but that is just more noise and even less clean code than there was to begin with.

These are just my opions and I can be convinced otherwise.

That's fair enough; autopep8 looks reasonable. How about using autopep8 for formatting and then pycodestyle for stuff which autoformatters can't catch?

[shardros]

Sounds good to me

[shardros]

@Minion3665 would you like to do this?

[Minion3665]

@Minion3665 would you like to do this?

Sure thing; right now I'm at work so I'll do it when I'm on my break

[shardros]

Sure :) theres no huge rush

…

On Fri, 29 Jul 2022 at 10:08, Skyler ***@***.***> wrote: @Minion3665 <https://github.com/Minion3665> would you like to do this? Sure thing; right now I'm at work so I'll do it when I'm on my break — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADFYNLZK64T6FLGXMVA6CMDVWONPRANCNFSM5447HNJA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Minion3665]

Requiring status checks to pass is blocked by making this public (is this planned?) or paying for github

[shardros]

I see no reason why not to make it public.

…

On Mon, 15 Aug 2022 at 23:56, Skyler ***@***.***> wrote: [image: image] <https://user-images.githubusercontent.com/34243578/184734492-1ae316d3-c76f-4050-93b5-d75f53da5525.png> Requiring status checks to pass is blocked by making this public (is this planned?) or paying for github — Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADFYNL6PN3Q2FNO7N46ABC3VZLDKRANCNFSM5447HNJA> . You are receiving this because you were mentioned.Message ID: ***@***.***>