Skip to content

Commit 13dcfae

Browse files
committed
scripts: Version EC separately from SBIOS
The original rationale for having the EC version match the SBIOS version was to ensure that compatible versions of each were installed. So we set the EC version to the SBIOS version and always flash both of them, even if only one actually changed. At some point, a mechanism should be implemented that checks for a minimum supported/compatible version. This would be comparable to the LVFS MetaInfo's "requires" field. Ref: f4f4d5b ("Build EC as a submodule, specifying version") Signed-off-by: Tim Crawford <[email protected]>
1 parent 51f639a commit 13dcfae

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ features apply to your model and firmware version, see the
1212
- cml-u: Updated CSME to 14.1.74.2355v6 (14.1.74.2373)
1313
- Reverted unlock prompt change to restore intended behavior
1414
- darp10: Fixed reporting of the second fan
15+
- Changed the EC version to be distinct from the SBIOS version
1516

1617
## 2024-07-01
1718

scripts/_build/ec.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,5 @@ done < "$1"
2020
BUILD_DIR="build"
2121

2222
make -C ec BUILD="$BUILD_DIR" clean
23-
make -C ec VERSION="${VERSION}" "${EC_ARGS[@]}" BUILD="$BUILD_DIR" -j "$(nproc)"
23+
make -C ec "${EC_ARGS[@]}" BUILD="$BUILD_DIR" -j "$(nproc)"
2424
cp "ec/$BUILD_DIR/ec.rom" "$2"

scripts/build.sh

+1-2
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,7 @@ KERNELVERSION="${VERSION}" \
8787
# Rebuild EC firmware for System76 EC models
8888
if [ ! -e "${MODEL_DIR}/ec.rom" ] && [ -e "${MODEL_DIR}/ec.config" ]
8989
then
90-
env VERSION="${VERSION}" \
91-
./scripts/_build/ec.sh \
90+
./scripts/_build/ec.sh \
9291
"${MODEL_DIR}/ec.config" \
9392
"${BUILD}/ec.rom"
9493
fi

0 commit comments

Comments
 (0)