Skip to content

Commit 1394c18

Browse files
committed
scripts: Version EC separately from SBIOS
The original rationale for having the EC version match the SBIOS version was to ensure that compatible versions of each were installed. So we set the EC version to the SBIOS version and always flash both of them, even if only one actually changed. At some point, a mechanism should be implemented that checks for a minimum supported/compatible version. This would be comparable to the LVFS MetaInfo's "requires" field. Ref: f4f4d5b ("Build EC as a submodule, specifying version") Signed-off-by: Tim Crawford <[email protected]>
1 parent 698de20 commit 1394c18

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ features apply to your model and firmware version, see the
99
## unreleased
1010

1111
- meer9: Added initial release of open firmware
12+
- Changed the EC version to be distinct from the SBIOS version
1213

1314
## 2024-11-15
1415

scripts/_build/ec.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,5 @@ done < "$1"
2020
BUILD_DIR="build"
2121

2222
make -C ec BUILD="$BUILD_DIR" clean
23-
make -C ec VERSION="${VERSION}" "${EC_ARGS[@]}" BUILD="$BUILD_DIR" -j "$(nproc)"
23+
make -C ec "${EC_ARGS[@]}" BUILD="$BUILD_DIR" -j "$(nproc)"
2424
cp "ec/$BUILD_DIR/ec.rom" "$2"

scripts/build.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,7 @@ KERNELVERSION="${VERSION}" \
8787
# Rebuild EC firmware for System76 EC models
8888
if [ ! -e "${MODEL_DIR}/ec.rom" ] && [ -e "${MODEL_DIR}/ec.config" ]
8989
then
90-
env VERSION="${VERSION}" \
91-
./scripts/_build/ec.sh \
90+
./scripts/_build/ec.sh \
9291
"${MODEL_DIR}/ec.config" \
9392
"${BUILD}/ec.rom"
9493
fi

0 commit comments

Comments
 (0)