Skip to content

Commit aa3cac1

Browse files
crawfxrdcrawfxrd
committed
mb/system76: Use default GMA brightness levels
This reverts commit 1f81af5 ("mb/system76: Add custom backlight levels for Intel GMA"). Defaulting to 40% can make the screen hard to read as System76's firmware setup uses white text on a gray background. Change-Id: I13ab3797319c4db6e800737a3f4e4344e3b588f3 Signed-off-by: Tim Crawford <[email protected]>
1 parent f3ecbae commit aa3cac1

30 files changed

+10
-329
lines changed

‎src/mainboard/system76/adl/acpi/backlight.asl

Lines changed: 0 additions & 31 deletions
This file was deleted.

‎src/mainboard/system76/adl/acpi/mainboard.asl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
Scope (\_SB) {
1212
#include "sleep.asl"
1313
Scope (PCI0) {
14-
#include "backlight.asl"
15-
1614
#if CONFIG(DRIVERS_GFX_NVIDIA)
1715
Scope (PEG2) {
1816
#include <drivers/gfx/nvidia/acpi/tigerlake.asl>

‎src/mainboard/system76/adl/dsdt.asl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ DefinitionBlock(
2020
#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
2121
#include <soc/intel/alderlake/acpi/southbridge.asl>
2222
#include <soc/intel/alderlake/acpi/tcss.asl>
23+
#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
2324
}
2425

2526
#include <southbridge/intel/common/acpi/sleepstates.asl>

‎src/mainboard/system76/cml-u/acpi/backlight.asl

Lines changed: 0 additions & 31 deletions
This file was deleted.

‎src/mainboard/system76/cml-u/acpi/mainboard.asl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@
66

77
Scope (\_SB) {
88
#include "sleep.asl"
9-
Scope (PCI0) {
10-
#include "backlight.asl"
11-
}
129
}
1310

1411
Scope (\_GPE) {

‎src/mainboard/system76/cml-u/dsdt.asl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ DefinitionBlock(
1919
{
2020
#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
2121
#include <soc/intel/cannonlake/acpi/southbridge.asl>
22+
#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
2223
}
2324

2425
#include <southbridge/intel/common/acpi/sleepstates.asl>

‎src/mainboard/system76/gaze15/acpi/backlight.asl

Lines changed: 0 additions & 31 deletions
This file was deleted.

‎src/mainboard/system76/gaze15/acpi/mainboard.asl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
Scope (\_SB) {
1010
#include "sleep.asl"
1111
Scope (PCI0) {
12-
#include "backlight.asl"
1312
Device (PEGP) {
1413
Name (_ADR, CONFIG_DRIVERS_GFX_NVIDIA_BRIDGE << 16)
1514
#include <drivers/gfx/nvidia/acpi/coffeelake.asl>

‎src/mainboard/system76/gaze15/dsdt.asl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ DefinitionBlock(
1818
Device (\_SB.PCI0) {
1919
#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
2020
#include <soc/intel/cannonlake/acpi/southbridge.asl>
21+
#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
2122
}
2223

2324
#include <southbridge/intel/common/acpi/sleepstates.asl>

‎src/mainboard/system76/kbl-u/acpi/backlight.asl

Lines changed: 0 additions & 31 deletions
This file was deleted.

‎src/mainboard/system76/kbl-u/acpi/mainboard.asl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
/* SPDX-License-Identifier: GPL-2.0-only */
22

33
Scope (\_SB) {
4-
Scope (PCI0) {
5-
#include "backlight.asl"
6-
}
7-
84
#include "ac.asl"
95
#include "battery.asl"
106
#include "buttons.asl"

‎src/mainboard/system76/kbl-u/dsdt.asl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ DefinitionBlock(
1919
{
2020
#include <soc/intel/skylake/acpi/systemagent.asl>
2121
#include <soc/intel/skylake/acpi/pch.asl>
22+
#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
2223
}
2324

2425
#include <southbridge/intel/common/acpi/sleepstates.asl>

‎src/mainboard/system76/oryp5/acpi/backlight.asl

Lines changed: 0 additions & 31 deletions
This file was deleted.

‎src/mainboard/system76/oryp5/acpi/mainboard.asl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ Scope (\_SB)
1010
{
1111
#include "sleep.asl"
1212
Scope (PCI0) {
13-
#include "backlight.asl"
1413
Device (PEGP) {
1514
Name (_ADR, CONFIG_DRIVERS_GFX_NVIDIA_BRIDGE << 16)
1615
#include <drivers/gfx/nvidia/acpi/coffeelake.asl>

‎src/mainboard/system76/oryp5/dsdt.asl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ DefinitionBlock(
1919
{
2020
#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
2121
#include <soc/intel/cannonlake/acpi/southbridge.asl>
22+
#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
2223
}
2324

2425
#include <southbridge/intel/common/acpi/sleepstates.asl>

‎src/mainboard/system76/oryp6/acpi/backlight.asl

Lines changed: 0 additions & 31 deletions
This file was deleted.

‎src/mainboard/system76/oryp6/acpi/mainboard.asl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
Scope (\_SB) {
1010
#include "sleep.asl"
1111
Scope (PCI0) {
12-
#include "backlight.asl"
1312
Device (PEGP) {
1413
Name (_ADR, CONFIG_DRIVERS_GFX_NVIDIA_BRIDGE << 16)
1514
#include <drivers/gfx/nvidia/acpi/coffeelake.asl>

‎src/mainboard/system76/oryp6/dsdt.asl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ DefinitionBlock(
1818
Device (\_SB.PCI0) {
1919
#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
2020
#include <soc/intel/cannonlake/acpi/southbridge.asl>
21+
#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
2122
}
2223

2324
#include <southbridge/intel/common/acpi/sleepstates.asl>

‎src/mainboard/system76/rpl/acpi/backlight.asl

Lines changed: 0 additions & 31 deletions
This file was deleted.

‎src/mainboard/system76/rpl/acpi/mainboard.asl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
Scope (\_SB) {
1212
#include "sleep.asl"
1313
Scope (PCI0) {
14-
#include "backlight.asl"
15-
1614
#if CONFIG(DRIVERS_GFX_NVIDIA)
1715
#if CONFIG(SOC_INTEL_ALDERLAKE_PCH_P) || CONFIG(BOARD_SYSTEM76_BONW15)
1816
Scope (PEG2) {

‎src/mainboard/system76/rpl/dsdt.asl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ DefinitionBlock(
2020
#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
2121
#include <soc/intel/alderlake/acpi/southbridge.asl>
2222
#include <soc/intel/alderlake/acpi/tcss.asl>
23+
#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
2324
}
2425

2526
#include <southbridge/intel/common/acpi/sleepstates.asl>

‎src/mainboard/system76/tgl-h/acpi/backlight.asl

Lines changed: 0 additions & 31 deletions
This file was deleted.

‎src/mainboard/system76/tgl-h/acpi/mainboard.asl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
Scope (\_SB) {
1010
#include "sleep.asl"
1111
Scope (PCI0) {
12-
#include "backlight.asl"
1312
Scope (PEG1) {
1413
#include <drivers/gfx/nvidia/acpi/tigerlake.asl>
1514
}

‎src/mainboard/system76/tgl-h/dsdt.asl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ DefinitionBlock(
2020
#include <soc/intel/common/block/acpi/acpi/northbridge.asl>
2121
#include <soc/intel/tigerlake/acpi/southbridge.asl>
2222
#include <soc/intel/tigerlake/acpi/tcss.asl>
23+
#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
2324
}
2425

2526
#include <southbridge/intel/common/acpi/sleepstates.asl>

0 commit comments

Comments
 (0)