Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replying to reply is broken #462

Open
notramo opened this issue Dec 23, 2021 · 1 comment
Open

Replying to reply is broken #462

notramo opened this issue Dec 23, 2021 · 1 comment

Comments

@notramo
Copy link
Contributor

notramo commented Dec 23, 2021

Replies contain fallback quoting of original message. Element filters these fallback texts out, so only the last message is quoted. Syphon doesn't filter out the reply quotes, so it gets unreadable garbage with a long reply chain.

Steps to reproduce

  1. Send a message
  2. Reply to that message
  3. Reply to the message sent in step 2.

If the message in step 3 was sent from Element, it only contains step 2 as a quote. If it's from Syphon, then step 1 and step 2 are quoted, with wrong formatting.

How to fix it?

When inserting fallback quotes:

  1. Filter out the first Markdown blockquote in unformatted text
  2. Filter out text inside <mx-reply> tag from the start of formatted_text
@EdGeraghty
Copy link
Collaborator

This is related to #529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants