Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themability of font-related properties? #1

Open
scottyeck opened this issue Oct 2, 2015 · 1 comment
Open

Themability of font-related properties? #1

scottyeck opened this issue Oct 2, 2015 · 1 comment

Comments

@scottyeck
Copy link

I don't quite understand why, but font-related properties (eg. font-family, font-size, line-height etc.) seem to be the only ones that are not themable once this partial is imported. There are more than likely plenty of scenarios (my own being one of them, as it just so happens 😄 ), wherein a user may prefer a different font-size or a different (although likely still monospaced) font-family.

Was there a reason for their exclusion?

FWIW, I suppose I should probably provide a little context for my use case.

I understand that this module is shipped alongside syntaxhighlighter. I've chosen to work with node-syntaxhighlighter (as it is syntactically somewhat lighter and as such better suited for my application), but this package ships only with CSS. As such, I've taken advantage of the standalone theming partial you've provided here for use with the main package.

Aside from the font issue discussed above, I think this seems to be a pretty solid plan. Including font-properties will enhance the abilities of this module as a standalone as well as create flexibility for any themes built for syntaxhighlighter in the future.

@scottyeck
Copy link
Author

@alexgorbatchev Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant