Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Set status and publish events in Destination to indicate if test files are successfully written #330

Open
ChunyiLyu opened this issue Jan 22, 2025 · 3 comments · May be fixed by #343
Open

feat: Set status and publish events in Destination to indicate if test files are successfully written #330

ChunyiLyu opened this issue Jan 22, 2025 · 3 comments · May be fixed by #343
Assignees
@kirederik
Labels
epic/debugging

Comments

@ChunyiLyu
Copy link
Member

Context

Destination should have status field to indicate to users feedback whether the creation is successful.

We write canary resource files, a namespace and a configmap, to Destinations. Provide user feedback in the status on whether the write is successful.

Given user has created a Destination
Given this Destination references an existing StateStore that can be written to
Then Destination has a Status field telling users that writing canary files were successful
Then Kratix publishes a successful write event to the Destination

Given user has created a Destination
When this Destination references a StateStore that kratix cannot write to
Then users are informed in kratix logs, Destination Status, and events of the Destination
@ChunyiLyu ChunyiLyu mentioned this issue Jan 22, 2025
Closed
@ChunyiLyu
Copy link
Member Author

Similar issue for StateStore #247

@ChunyiLyu ChunyiLyu mentioned this issue Jan 22, 2025
Open
@catmo-syntasso
Copy link
Member

q: what are the implications of adding a free-form field to this as well? Similar to the status & details components we've just added for health checks?

@kirederik kirederik self-assigned this Jan 30, 2025
kirederik added a commit that referenced this issue Jan 30, 2025
@kirederik
feat(#330): add destination status and events
a369135
@kirederik
Copy link
Member

asciicast

status and events in action!

kirederik added a commit that referenced this issue Jan 31, 2025
@kirederik
feat(#330): add destination status and events
cb23a9c
kirederik added a commit that referenced this issue Jan 31, 2025
@kirederik
chore(#330): add system-tests for destination
3c915e8
@kirederik kirederik linked a pull request Jan 31, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirederik kirederik

Labels
epic/debugging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat/330/add destination status syntasso/kratix
3 participants
@kirederik @ChunyiLyu @catmo-syntasso