Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker support #49

Open
adrian-kong opened this issue Oct 2, 2023 · 1 comment
Open

Docker support #49

adrian-kong opened this issue Oct 2, 2023 · 1 comment

Comments

@adrian-kong
Copy link

Running in docker gives

      "mainEventFilePathname" : "/__w/starling-core/starling-core/public_types/src/external_functions.cc",
@adrian-kong
Copy link
Author

This is due to:

export function relativizePath(path: string): string {
let length = process.env.GITHUB_WORKSPACE?.length
if (!length) {
length = 'undefined'.length
}
return path.substring(length + 1)
}

which matches based on GITHUB_WORKSPACE which is /home/runner/work/starling-core/starling-core

Creates additional issues for

  • creating issues instead of reviews since file can never be matched.
  • linking issues URL is incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant