Skip to content
This repository has been archived by the owner on Jun 14, 2019. It is now read-only.

Connections list page: disabled 'delete' menu item still triggers a delete confirmation #208

Closed
gashcrumb opened this issue Apr 30, 2019 · 2 comments
Closed

Connections list page: disabled 'delete' menu item still triggers a delete confirmation #208

gashcrumb opened this issue Apr 30, 2019 · 2 comments
Assignees
@elvisisking
Labels
notif/triage

Comments

@gashcrumb
Copy link
Collaborator

This is a...


[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Documentation issue or request

Description

Spotted it, so logging it:

image
@gashcrumb
Copy link
Collaborator Author

probably this menu item should use a button link, as you can't actually disable an anchor tag.

@elvisisking elvisisking self-assigned this May 29, 2019
elvisisking added a commit to elvisisking/syndesis-react-poc that referenced this issue May 30, 2019
@elvisisking
The connections list page's disabled 'delete' menu item no longer tri…
9860f25 
…ggers a delete confirmation

- See syndesisio#208
- ConnectionCard uses PF4 Dropdown
- Fixes a regression bug in ConnectionDetailsForm that kept the cancel and save buttons always visible
- Added property to PfDropdownItem that indicates if item should be disabled
- Added a ConnectionDetailsForm story
@elvisisking elvisisking mentioned this issue May 30, 2019
Merged
@elvisisking
Copy link
Contributor

Fixed by #374

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@elvisisking elvisisking

Labels
notif/triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gashcrumb @elvisisking