Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder selection overlays the keyboard #1877

Open
shanks1337 opened this issue Dec 31, 2022 · 4 comments
Open

Folder selection overlays the keyboard #1877

shanks1337 opened this issue Dec 31, 2022 · 4 comments

Comments

@shanks1337
Copy link

Folder selection overlays the keyboard

Screenshot_20221216-025756
Screenshot_20221216-025912

Using the back gesture to close the keyboard won't close the overlay

Version Information

App Version: 1.22.2
Syncthing Version: v1.22.2
Android Version: Android 13
@tomasz1986
Copy link
Contributor

Is this stock(ish) Android? I can actually reproduce the problem on a Samsung device running Android 12 but it would be good to know whether this affects Android in general or not. Because this is about the Web GUI itself and not the Android app, the issue belongs to https://github.com/syncthing/syncthing/issues really, not to this repository.

However, I'm not sure whether this alone is worth having a separate issue though (as these kind of small glitches are nothing new when it comes to the Web GUI 😛). Honestly, as long as things are still usable, I wouldn't bother too much, unless you're going to make a pull request and fix the problem yourself.

@shanks1337
Copy link
Author

This was tested on a Google Pixel 7, so yeah stock(ish) / vanilla Android + the Pixel specific features.

It's useable but it makes it more difficult. Sometimes the back button can barly be reached or the first row of keyboard button is not available due the cover of the overlay. As I mentioned, the back gesture which closes the keyboard won't close the path suggestions as well. Using the back gesture again brings you back to previous screen. I include two more screenshots to maybe illustrate the problem a little bit better when more path options are available.

Screenshot_20221231-024735
Screenshot_20221231-024659

@tomasz1986
Copy link
Contributor

Yeah, the overlay positioning seems somewhat broken, and also it would probably be good to limit the number of entries displayed on the screen (with a possibility to scroll the list when needed). I may have a look at this later on.

@wweich
Copy link
Member

wweich commented Jan 2, 2023

I'm pretty sure, this isn't actually our overlay, but a "normal" drop down list, rendered by Android. The position in the first screenshots however suggest, that we (or the old Bootstrap version we use) don't position the invisible drop down field correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants