v16.4.48 is released

Author: pipeline

controls/base/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@syncfusion/ej2-base",
-	"version": "16.4.42",
+	"version": "16.4.47",
 	"description": "A common package of Essential JS 2 base libraries, methods and class definitions",
 	"author": "Syncfusion Inc.",
 	"license": "SEE LICENSE IN license",

controls/base/styles/common/_icons.scss

@@ -1,6 +1,6 @@
 {
 	"name": "@syncfusion/ej2-buttons",
-	"version": "16.4.42",
+	"version": "16.4.47",
 	"description": "A package of feature-rich Essential JS 2 components such as Button, CheckBox, RadioButton and Switch.",
 	"author": "Syncfusion Inc.",
 	"license": "SEE LICENSE IN license",

controls/buttons/ReadMe.md renamed to controls/buttons/README.md

@@ -1,10 +1,21 @@
 import { Button } from '../src/button/button';
 import { createElement, detach } from '@syncfusion/ej2-base';
+import { profile , inMB, getMemoryProfile } from './common.spec';
+
 /**
  * @param  {} 'Button'
  * @param  {} function(
  */
 describe('Button', () => {
+    beforeAll(() => {
+        const isDef: any = (o: any) => o !== undefined && o !== null;
+        if (!isDef(window.performance)) {
+            console.log('Unsupported environment, window.performance.memory is unavailable');
+            this.skip(); // skips test (in Chai)
+            return;
+        }
+    });
+
     let button: Button;
     let element: any = createElement('button', { id: 'button' });
     document.body.appendChild(element);
@@ -329,4 +340,14 @@ describe('Button', () => {
             Button.Inject();
         });
     });
+
+    it('memory leak', () => {
+        profile.sample();
+        let average: any = inMB(profile.averageChange);
+        // check average change in memory samples to not be over 10MB
+        expect(average).toBeLessThan(10);
+        let memory: any = inMB(getMemoryProfile());
+        // check the final memory usage against the first usage, there should be little change if everything was properly deallocated
+        expect(memory).toBeLessThan(profile.samples[0] + 0.25);
+    });
 });

controls/buttons/package.json

@@ -1,11 +1,21 @@
 import { createCheckBox } from './../src/common/common';
 import { CheckBox } from './../src/check-box/check-box';
 import { createElement } from '@syncfusion/ej2-base';
+import { profile , inMB, getMemoryProfile } from './common.spec';
 
 /**
  * CheckBox Spec document
  */
 describe('CheckBox', () => {
+    beforeAll(() => {
+        const isDef: any = (o: any) => o !== undefined && o !== null;
+        if (!isDef(window.performance)) {
+            console.log('Unsupported environment, window.performance.memory is unavailable');
+            this.skip(); // skips test (in Chai)
+            return;
+        }
+    });
+
     let checkbox: any;
     let element: HTMLFormElement = createElement('input', { id: 'checkbox' }) as HTMLFormElement;
     element.setAttribute('type', 'checkbox');
@@ -351,4 +361,14 @@ describe('CheckBox', () => {
             expect(checkboxElem.classList.contains('e-rtl')).toBe(true);
         });
     });
+
+    it('memory leak', () => {
+        profile.sample();
+        let average: any = inMB(profile.averageChange);
+        // check average change in memory samples to not be over 10MB
+        expect(average).toBeLessThan(10);
+        let memory: any = inMB(getMemoryProfile());
+        // check the final memory usage against the first usage, there should be little change if everything was properly deallocated
+        expect(memory).toBeLessThan(profile.samples[0] + 0.25);
+    });
 });

controls/buttons/spec/button.spec.ts

@@ -0,0 +1,35 @@
+interface Window {
+    performance: { memory: any };
+}
+
+declare var window: Window
+
+export const inMB: any = (n: any) => n / 1000000;
+
+function runningAverage(arr: any, newVal: any, oldAvg: any) {
+    return ((oldAvg * (arr.length - 1) + newVal) / arr.length);
+};
+
+export const getMemoryProfile: any = () => {
+    return window.performance.memory.usedJSHeapSize; // return used memory
+};
+
+export const profile: any = {
+    samples: [] as any,
+    diffs: [] as any,
+    averageUsage: 0,
+    averageChange: 0,
+    // collects a sample of memory and updates all the values in the
+    // profile object
+    sample() {
+        let newSample: any = getMemoryProfile();
+        this.samples.push(newSample);
+        this.averageUsage = runningAverage(this.samples, newSample, this.averageUsage);
+        let sampleLen: any = this.samples.length;
+        if (sampleLen >= 2) {
+            let newDiff: any = this.samples[sampleLen - 1] - this.samples[sampleLen - 2];
+            this.diffs.push(newDiff);
+            this.averageChange = runningAverage(this.diffs, newDiff, this.averageChange);
+        }
+    }
+};

controls/buttons/spec/check-box.spec.ts

@@ -1,10 +1,20 @@
 import { RadioButton } from './../src/radio-button/radio-button';
 import { createElement } from '@syncfusion/ej2-base';
+import { profile , inMB, getMemoryProfile } from './common.spec';
 
 /**
  * RadioButton Spec document
  */
 describe('RadioButton', () => {
+    beforeAll(() => {
+        const isDef: any = (o: any) => o !== undefined && o !== null;
+        if (!isDef(window.performance)) {
+            console.log('Unsupported environment, window.performance.memory is unavailable');
+            this.skip(); // skips test (in Chai)
+            return;
+        }
+    });
+
     let radio: any;
     let element: HTMLFormElement = createElement('input', { id: 'radio' }) as HTMLFormElement;
     element.setAttribute('type', 'radio');
@@ -263,4 +273,14 @@ describe('RadioButton', () => {
             expect(radio.element.type).toEqual('radio');
         });
     });
+
+    it('memory leak', () => {
+        profile.sample();
+        let average: any = inMB(profile.averageChange);
+        // check average change in memory samples to not be over 10MB
+        expect(average).toBeLessThan(10);
+        let memory: any = inMB(getMemoryProfile());
+        // check the final memory usage against the first usage, there should be little change if everything was properly deallocated
+        expect(memory).toBeLessThan(profile.samples[0] + 0.25);
+    });
 });

controls/buttons/spec/common.spec.ts

@@ -1,6 +1,7 @@
 import { Switch } from './../src/switch/switch';
 import { createElement } from '@syncfusion/ej2-base';
 import { EventHandler } from '@syncfusion/ej2-base';
+import { profile , inMB, getMemoryProfile } from './common.spec';
 
 /* tslint:disable */
 function copyObject(source: any, destination: any): Object {
@@ -30,6 +31,15 @@ export function getEventObject(eventType: string, eventName: string): Object {
  * Switch Spec document.
  */
 describe('Switch', () => {
+    beforeAll(() => {
+        const isDef: any = (o: any) => o !== undefined && o !== null;
+        if (!isDef(window.performance)) {
+            console.log('Unsupported environment, window.performance.memory is unavailable');
+            this.skip(); // skips test (in Chai)
+            return;
+        }
+    });
+
     let specSwitch: any;
     let element: HTMLFormElement = createElement('input', {id: 'specSwitch'}) as HTMLFormElement;
     element.setAttribute('type', 'checkbox');
@@ -322,5 +332,15 @@ describe('Switch', () => {
             expect(specSwitch.checked).toEqual(false);
         })
     });
+
+    it('memory leak', () => {
+        profile.sample();
+        let average: any = inMB(profile.averageChange);
+        // check average change in memory samples to not be over 10MB
+        expect(average).toBeLessThan(10);
+        let memory: any = inMB(getMemoryProfile());
+        // check the final memory usage against the first usage, there should be little change if everything was properly deallocated
+        expect(memory).toBeLessThan(profile.samples[0] + 0.25);
+    });
 });
 

controls/buttons/spec/radio-button.spec.ts

@@ -2,7 +2,15 @@
 
 ## [Unreleased]
 
-## 16.4.47 (2019-01-08)
+## 16.4.48 (2019-01-16)
+
+### TimePicker
+
+#### Breaking Changes
+
+- TimePicker pop-up will position at the center of the viewport in mobile resolution.
+
+## 16.4.47 (2019-01-16)
 
 ### TimePicker