Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make assign public IP default better #38

Open
dragonfleas opened this issue May 30, 2024 · 0 comments
Open

Make assign public IP default better #38

dragonfleas opened this issue May 30, 2024 · 0 comments
Assignees

Comments

@dragonfleas
Copy link
Contributor

Description

The assign_public_ip is set to false as the default for the ECS service resource. Since we primarily use Fargate containers which by default utilize (and require) the awsvpc network type also requiring the auto assign public IP to be true, we should change the default to be true, or make it a required variable. I'd opt for the former considering backwards compatibility.

Reference

variable "assign_public_ip" {
type = bool
description = "Whether or not to assign a public IP to the task"
default = false
}

@dragonfleas dragonfleas self-assigned this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant