Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OS- and CPU- specific artifacts when downloading from NATS #395

Open
autodidaddict opened this issue Oct 8, 2024 · 0 comments
Labels
proposal Enhancement idea or proposal

Comments

@autodidaddict
Copy link
Contributor

Proposed change

Add a bit of intelligence to artifact downloading:

  • If the workload type is function (JavaScript or wasm), no changes
  • If the workload type is native:
    • Attempt to download {path}_{os}_{arch} (e.g. echoservice_darwin_amd64) where os and arch are the operating system and CPU architecture of the Nex node attempting to download the artifact
    • If no such artifact exists, try and download just {path}

Use case

In the current version of Nex, it will pull whatever artifact is indicated by the URL in the start workload request. This means that if you accidentally give Nex the URL for a darwin artifact and send it to a Nex node running on Linux, the workload will fail to start.

This would allow for Nex nodes running on different CPUs and operating systems to all be given the same start workload command and it will "just work" and download the appropriate binary

Contribution

No response

@autodidaddict autodidaddict added the proposal Enhancement idea or proposal label Oct 8, 2024
@autodidaddict autodidaddict changed the title Add support for OS- and CPU- specific artifacts when downloading Add support for OS- and CPU- specific artifacts when downloading from NATS Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Enhancement idea or proposal
Projects
None yet
Development

No branches or pull requests

1 participant