From f0972c7fc76bf749f624806b222671f7b93ba028 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Wed, 24 Jul 2024 23:31:17 +0200 Subject: [PATCH 1/2] add failing iterator fixture --- .../Fixture/iterator_flip.php.inc | 19 +++++++++++++++++++ .../ParamReturnAndVarTagMalformsFixerTest.php | 3 --- 2 files changed, 19 insertions(+), 3 deletions(-) create mode 100644 tests/Fixer/Commenting/ParamReturnAndVarTagMalformsFixer/Fixture/iterator_flip.php.inc diff --git a/tests/Fixer/Commenting/ParamReturnAndVarTagMalformsFixer/Fixture/iterator_flip.php.inc b/tests/Fixer/Commenting/ParamReturnAndVarTagMalformsFixer/Fixture/iterator_flip.php.inc new file mode 100644 index 00000000..be381142 --- /dev/null +++ b/tests/Fixer/Commenting/ParamReturnAndVarTagMalformsFixer/Fixture/iterator_flip.php.inc @@ -0,0 +1,19 @@ + */ + return $value; +} + +?> +----- + $value */ + return $value; +} + +?> diff --git a/tests/Fixer/Commenting/ParamReturnAndVarTagMalformsFixer/ParamReturnAndVarTagMalformsFixerTest.php b/tests/Fixer/Commenting/ParamReturnAndVarTagMalformsFixer/ParamReturnAndVarTagMalformsFixerTest.php index baa16e6f..393d4531 100644 --- a/tests/Fixer/Commenting/ParamReturnAndVarTagMalformsFixer/ParamReturnAndVarTagMalformsFixerTest.php +++ b/tests/Fixer/Commenting/ParamReturnAndVarTagMalformsFixer/ParamReturnAndVarTagMalformsFixerTest.php @@ -8,9 +8,6 @@ use PHPUnit\Framework\Attributes\DataProvider; use Symplify\EasyCodingStandard\Testing\PHPUnit\AbstractCheckerTestCase; -/** - * @mimic https://github.com/rectorphp/rector/pull/807/files - */ final class ParamReturnAndVarTagMalformsFixerTest extends AbstractCheckerTestCase { #[DataProvider('provideData')] From 8bc13642f258b8f66a5fc02f261295f67e5f95de Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Wed, 24 Jul 2024 23:35:38 +0200 Subject: [PATCH 2/2] fix --- .../DocBlock/MalformWorker/SwitchedTypeAndNameMalformWorker.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/TokenRunner/DocBlock/MalformWorker/SwitchedTypeAndNameMalformWorker.php b/src/TokenRunner/DocBlock/MalformWorker/SwitchedTypeAndNameMalformWorker.php index 0cf3ede3..b9cb6095 100644 --- a/src/TokenRunner/DocBlock/MalformWorker/SwitchedTypeAndNameMalformWorker.php +++ b/src/TokenRunner/DocBlock/MalformWorker/SwitchedTypeAndNameMalformWorker.php @@ -16,7 +16,7 @@ final class SwitchedTypeAndNameMalformWorker implements MalformWorkerInterface * @var string * @see https://regex101.com/r/4us32A/1 */ - private const NAME_THEN_TYPE_REGEX = '#@((?:psalm-|phpstan-)?(?:param|var))(\s+)(?\$\w+)(\s+)(?[|\\\\\w\[\]]+)#'; + private const NAME_THEN_TYPE_REGEX = '#@((?:psalm-|phpstan-)?(?:param|var))(\s+)(?\$\w+)(\s+)(?[|\\\\\w\[\]\<\>]+)#'; /** * @param Tokens $tokens