Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming Data Sources #13

Open
nilshoerrmann opened this issue Jun 5, 2012 · 4 comments
Open

Renaming Data Sources #13

nilshoerrmann opened this issue Jun 5, 2012 · 4 comments

Comments

@nilshoerrmann
Copy link
Contributor

When a Data Source that is included in a Union Data Source has been renamed, front-end and Data Source editor break with the following error:

Symphony Fatal Error: Could not find Data Source stream. If it was provided by an Extension, ensure that it is installed, and enabled.

176         public static function create($handle, array $env = null, $process_params=true){
177             $classname = self::__getClassName($handle);
178             $path = self::__getDriverPath($handle);
179
180             if(!is_file($path)){
181                 throw new Exception(
182                     __('Could not find Data Source %s.', array('<code>' . $handle . '</code>'))
183                     . ' ' . __('If it was provided by an Extension, ensure that it is installed, and enabled.')
184                 );
185             }
@nilshoerrmann
Copy link
Contributor Author

In my eyes, Union DS should not break but just ignore the missing DS by either saving an error in the logs, displaying a system message in the DS editor and/or adding a note to the front-end XML (<error type="missing" handle="handle-of-missing-ds">name of missing DS</error>).

@brendo
Copy link
Member

brendo commented Jun 6, 2012

I agree, it's actually exposed a bit of a hole in the DatasourcePostEdit and EventPostEdit delegates as these don't give you any indication if the datasource or event has been renamed.

Something to fix for 2.3.1 :)

@brendo brendo closed this as completed in 9c97e33 Jun 6, 2012
@brendo brendo reopened this May 9, 2013
@brendo
Copy link
Member

brendo commented May 9, 2013

It's now possible to do this, so I should do it.

@nilshoerrmann
Copy link
Contributor Author

I just reencountered this issue so what needs to be done to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants