-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enableBuildNotifications
should not be enabled by default
#1161
Comments
enableBuildNotifications
should not be on by defaultenableBuildNotifications
should not be enabled by default
I'm also in favor in this, I've always removed the I never found those notifications very useful, but that's just my opinion. |
I'm fine with disabling by default - it would be over in the recipe - https://github.com/symfony/recipes/blob/main/symfony/webpack-encore-bundle/1.10/webpack.config.js - we could also then remove https://github.com/symfony/recipes/blob/main/symfony/webpack-encore-bundle/1.10/package.json#L12 Cheers! |
Thank you for this issue. |
No |
@jennevdmeer are you willing to contribute to remove this from the recipe (see the links in @weaverryan's comment above for the places needing to be changed) ? Edit: those links go to the recipe for the 1.10 version, while changes now should be done in the recipe for the highest version, which means the 2.0 recipe now (or in all versions) |
@stof I could, thought about it with the new notice. But I wanted to create a similar message to those "enableSassLoader requires sass use npm i sass sass-loader --save-dev" like messages when you would enable it and start the dev server. Which I would assume would be a good idea to add for this too then. I wanted to look at it but haven't had the time to figure that out yet. If you think the message is not needed I can just do it tomorrow'ish. |
@jennevdmeer Encore already makes the build notifications optional (and disabled by default), with such a message if the dependency is missing. |
Why does default encore come with
enableBuildNotifications
on by default. Maybe it's my hate for notifications but In general I feel like things should not just install/run "random" binaries by default.It comes from
..\encore-test\node_modules\node-notifier\vendor\snoreToast\snoretoast-x64.exe
. And for me on windows it even created a shortcut in my start menu without any consent. While at the same time not removing it when I remove encore (or npm'snode-notifier
).I feel like the consequences of that enabled should be clearly explained in the config and manually be enabled.
The text was updated successfully, but these errors were encountered: