From a63bb80c1b9b9edb991e8946370c40ec56522242 Mon Sep 17 00:00:00 2001 From: Oskar Stark Date: Mon, 28 Apr 2025 20:38:03 +0200 Subject: [PATCH 1/4] Support `Status: Waiting feedback` --- src/Api/Status/GitHubStatusApi.php | 1 + src/Api/Status/Status.php | 1 + 2 files changed, 2 insertions(+) diff --git a/src/Api/Status/GitHubStatusApi.php b/src/Api/Status/GitHubStatusApi.php index ac14703..4692113 100644 --- a/src/Api/Status/GitHubStatusApi.php +++ b/src/Api/Status/GitHubStatusApi.php @@ -13,6 +13,7 @@ class GitHubStatusApi implements StatusApi Status::NEEDS_WORK => 'Status: Needs Work', Status::WORKS_FOR_ME => 'Status: Works for me', Status::REVIEWED => 'Status: Reviewed', + Status::WAITING_FEEDBACK => 'Status: Waiting feedback', ]; private array $labelToStatus; diff --git a/src/Api/Status/Status.php b/src/Api/Status/Status.php index 88cb3b2..32bb4be 100644 --- a/src/Api/Status/Status.php +++ b/src/Api/Status/Status.php @@ -13,4 +13,5 @@ final class Status public const string NEEDS_WORK = 'needs_work'; public const string WORKS_FOR_ME = 'works_for_me'; public const string REVIEWED = 'reviewed'; + public const string WAITING_FEEDBACK = 'waiting_feedback'; } From 83157774f519de502ca1b169e2106c8155429738 Mon Sep 17 00:00:00 2001 From: Oskar Stark Date: Tue, 29 Apr 2025 09:06:54 +0200 Subject: [PATCH 2/4] - --- tests/Api/Status/GitHubStatusApiTest.php | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/Api/Status/GitHubStatusApiTest.php b/tests/Api/Status/GitHubStatusApiTest.php index b75f090..5ff3813 100644 --- a/tests/Api/Status/GitHubStatusApiTest.php +++ b/tests/Api/Status/GitHubStatusApiTest.php @@ -16,7 +16,6 @@ class GitHubStatusApiTest extends TestCase { public const USER_NAME = 'weaverryan'; - public const REPO_NAME = 'carson'; /** From 0b63111de711deca1dedf8af42c150e5b7280c77 Mon Sep 17 00:00:00 2001 From: Oskar Stark Date: Tue, 29 Apr 2025 09:07:46 +0200 Subject: [PATCH 3/4] - --- src/Subscriber/AbstractStatusChangeSubscriber.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Subscriber/AbstractStatusChangeSubscriber.php b/src/Subscriber/AbstractStatusChangeSubscriber.php index 11d9a90..3247cac 100644 --- a/src/Subscriber/AbstractStatusChangeSubscriber.php +++ b/src/Subscriber/AbstractStatusChangeSubscriber.php @@ -13,6 +13,7 @@ abstract class AbstractStatusChangeSubscriber implements EventSubscriberInterfac 'needs work' => Status::NEEDS_WORK, 'works for me' => Status::WORKS_FOR_ME, 'reviewed' => Status::REVIEWED, + 'waiting_feedback' => Status::WAITING_FEEDBACK, ]; public function __construct( From 8997f6a68a218fe3e61001c880b5fdcdeb3282f0 Mon Sep 17 00:00:00 2001 From: Oskar Stark Date: Mon, 5 May 2025 11:11:06 +0200 Subject: [PATCH 4/4] Update src/Subscriber/AbstractStatusChangeSubscriber.php Co-authored-by: Christian Flothmann --- src/Subscriber/AbstractStatusChangeSubscriber.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Subscriber/AbstractStatusChangeSubscriber.php b/src/Subscriber/AbstractStatusChangeSubscriber.php index 3247cac..2955e21 100644 --- a/src/Subscriber/AbstractStatusChangeSubscriber.php +++ b/src/Subscriber/AbstractStatusChangeSubscriber.php @@ -13,7 +13,7 @@ abstract class AbstractStatusChangeSubscriber implements EventSubscriberInterfac 'needs work' => Status::NEEDS_WORK, 'works for me' => Status::WORKS_FOR_ME, 'reviewed' => Status::REVIEWED, - 'waiting_feedback' => Status::WAITING_FEEDBACK, + 'waiting feedback' => Status::WAITING_FEEDBACK, ]; public function __construct(