Make sure we are actually closing issues too

Author: Nyholm

config/services.yaml

@@ -83,6 +83,8 @@ services:
 
     Github\Api\Issue\Comments:
         factory: ['@Github\Api\Issue', comments]
+        calls:
+            - [ 'setPerPage', [ 100 ] ]
 
     App\Api\Issue\IssueApi: '@App\Api\Issue\GithubIssueApi'
     App\Api\Label\LabelApi: '@App\Api\Label\GithubLabelApi'

src/Api/Issue/GithubIssueApi.php

@@ -44,6 +44,14 @@ public function open(Repository $repository, string $title, string $body, array
         }
     }
 
+    public function lastCommentWasMadeByBot(Repository $repository, $number): bool
+    {
+        $allComments = $this->issueCommentApi->all($repository->getVendor(), $repository->getName(), $number);
+        $lastComment = $allComments[count($allComments) - 1] ?? [];
+
+        return $this->botUsername === ($lastComment['user']['login'] ?? null);
+    }
+
     public function close(Repository $repository, $issueNumber)
     {
         $this->issueApi->update($repository->getVendor(), $repository->getName(), $issueNumber, ['state' => 'closed']);

src/Api/Issue/IssueApi.php

@@ -19,6 +19,8 @@ public function open(Repository $repository, string $title, string $body, array
 
     public function commentOnIssue(Repository $repository, $issueNumber, string $commentBody);
 
+    public function lastCommentWasMadeByBot(Repository $repository, $number): bool;
+
     /**
      * Close an issue or a pull request.
      */

src/Api/Issue/NullIssueApi.php

@@ -14,6 +14,11 @@ public function commentOnIssue(Repository $repository, $issueNumber, string $com
     {
     }
 
+    public function lastCommentWasMadeByBot(Repository $repository, $number): bool
+    {
+        return false;
+    }
+
     public function close(Repository $repository, $issueNumber)
     {
     }

src/Command/CloseStaleIssuesCommand.php

@@ -3,7 +3,9 @@
 namespace App\Command;
 
 use App\Api\Issue\IssueApi;
+use App\Entity\Task;
 use App\Service\RepositoryProvider;
+use App\Service\TaskScheduler;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
@@ -19,12 +21,14 @@ class CloseStaleIssuesCommand extends Command
     protected static $defaultName = 'app:issue:close-stale';
     private $repositoryProvider;
     private $issueApi;
+    private $scheduler;
 
-    public function __construct(RepositoryProvider $repositoryProvider, IssueApi $issueApi)
+    public function __construct(RepositoryProvider $repositoryProvider, IssueApi $issueApi, TaskScheduler $scheduler)
     {
         parent::__construct();
         $this->repositoryProvider = $repositoryProvider;
         $this->issueApi = $issueApi;
+        $this->scheduler = $scheduler;
     }
 
     protected function configure()
@@ -57,7 +61,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
 TXT
 );
 
-            // TODO add a scheduled task to process this issue again after 2 weeks
+            // add a scheduled task to process this issue again after 2 weeks
+            $this->scheduler->runLater($repository, $issue['number'], Task::ACTION_CLOSE_STALE, new \DateTimeImmutable('+2weeks'));
         }
 
         return 0;

src/Service/TaskHandler/CloseStaleIssuesHandler.php

@@ -0,0 +1,49 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Service\TaskHandler;
+
+use App\Api\Issue\IssueApi;
+use App\Api\Label\LabelApi;
+use App\Api\PullRequest\PullRequestApi;
+use App\Entity\Task;
+use App\Service\RepositoryProvider;
+
+/**
+ * @author Tobias Nyholm <[email protected]>
+ */
+class CloseStaleIssuesHandler implements TaskHandlerInterface
+{
+    private $issueApi;
+    private $repositoryProvider;
+    private $labelApi;
+
+    public function __construct(LabelApi $labelApi, IssueApi $issueApi, RepositoryProvider $repositoryProvider)
+    {
+        $this->issueApi = $issueApi;
+        $this->repositoryProvider = $repositoryProvider;
+        $this->labelApi = $labelApi;
+    }
+
+    /**
+     * Close the issue if the last comment was made by the bot and if "Keep open" label does not exist.
+     */
+    public function handle(Task $task): void
+    {
+        $repository = $this->repositoryProvider->getRepository($task->getRepositoryFullName());
+        $labels = $this->labelApi->getIssueLabels($task->getNumber(), $repository);
+        if (in_array('Keep open', $labels)) {
+            return;
+        }
+
+        if ($this->issueApi->lastCommentWasMadeByBot($repository, $task->getNumber())) {
+            $this->issueApi->close($repository, $task->getNumber());
+        }
+    }
+
+    public function supports(Task $task): bool
+    {
+        return Task::ACTION_CLOSE_STALE === $task->getAction();
+    }
+}

src/Service/TaskScheduler.php

@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Service;
+
+use App\Entity\Task;
+use App\Model\Repository;
+use App\Repository\TaskRepository;
+
+/**
+ * Schedule a job to run later.
+ *
+ * @author Tobias Nyholm <[email protected]>
+ */
+class TaskScheduler
+{
+    private $taskRepo;
+
+    public function __construct(TaskRepository $taskRepo)
+    {
+        $this->taskRepo = $taskRepo;
+    }
+
+    public function runLater(Repository $repository, $number, int $action, \DateTimeImmutable $checkAt)
+    {
+        $task = new Task($repository->getFullName(), $number, $action, $checkAt);
+        $this->taskRepo->persist($task);
+        $this->taskRepo->flush();
+    }
+}