Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for DDS files. Have been really enjoying JPEGView but it's not able to open
.dds
files which are common in game development workflows.Closes #326.
Overview
BcnDecode.c
from the Python Pillow project from here.Limitations
DirectXTex
, I don't think I cover 100% of DDS subformats, especially more niche ones. However, I used Pillow's DDS support as a guideline and manually ensured parity between JPEGView and all .dds files Pillow uses in its testsThis is my first PR here - do let me know if I'm missing anything else that needs to be added when supporting additional file formats.
TODO
dds
variants listed here. Will probably use the test media provided here to validate my implementations.