Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color palettes #2035

Open
uncenter opened this issue Dec 12, 2024 · 2 comments
Open

Color palettes #2035

uncenter opened this issue Dec 12, 2024 · 2 comments
Labels
feature New feature request

Comments

@uncenter
Copy link
Contributor

uncenter commented Dec 12, 2024

Would like to revisit #200, but I can't comment on it to get it reopened so I'll just copy it here.

The default themes don't use hex codes, but rather colors like "red" and "lightyellow". It would make it a lot easier for people to make their own simple color palette themes, keeping the choice of blue for this component or whatever, but allowing them to use their own shades of that color.

[palette]
red = "#80AEFA"
green = "#CD9EFC"
white = "#FFA577"

https://starship.rs/ has this kind of thing, e.g. https://github.com/catppuccin/starship/blob/e99ba6b210c0739af2a18094024ca0bdf4bb3225/starship.toml#L23-L133. They support arbitrary color names too, which should ideally be the case here as well.

@uncenter uncenter added the feature New feature request label Dec 12, 2024
@sxyazi
Copy link
Owner

sxyazi commented Dec 15, 2024

What is its behavior under light and dark modes respectively? Specifically, can users use different color palettes for light and dark modes? If so, how can this be supported? If not, why?

@sxyazi sxyazi added the waiting on op Waiting for more information from the original poster label Dec 15, 2024
@uncenter
Copy link
Contributor Author

In the theme.toml light/dark could be supported by:

[palette.light]
red = "#80AEFA"
green = "#CD9EFC"
white = "#FFA577"

[palette.dark]
...

Or/in addition to that a palette could be used in flavor.toml (just the palette, nothing else) and then put under flavor.dark or flavor.light in the theme.toml like how flavors are used.

@github-actions github-actions bot removed the waiting on op Waiting for more information from the original poster label Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
None yet
Development

No branches or pull requests

2 participants