Skip to content
This repository was archived by the owner on Mar 24, 2025. It is now read-only.
This repository was archived by the owner on Mar 24, 2025. It is now read-only.

Static resources via symlink no longer work #481

Open
@aftabnaveed

Description

@aftabnaveed

Make sure you read Issues Guideline and answer these questions before submitting your issue. Thanks!
(Any non-English issues will be closed immediately.)

  1. Please provide your PHP and Swoole version. (php -v and php --ri swoole)

PHP 8.0.3 (cli) (built: Mar 4 2021 05:33:14) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.3, Copyright (c) Zend Technologies

Swoole => enabled
Author => Swoole Team [email protected]
Version => 4.6.4
Built => Mar 30 2021 15:39:43

  1. Please provide your Laravel/Lumen version.

Laravel 8.

  1. Which release version of this package are you using?

  2. What did you do? If possible, provide a recipe for reproducing the error.
    Created a Symlink in /public folder and set SWOOLE_HANDLE_STATIC to true in .env

  3. What did you expect to see?
    Expected to be able to see the static file from a symlink

  4. What did you see instead?
    404 Not Found

It looks like the following Merge broke the static resources served via symlink.

96a93e9#diff-5c6e8c22956d54a6193a50ec2c2ca80a8b2be45efa15faa70a2e5f9d0f29d380

 $fileName = @realpath($publicPath . $uri);

The above line in SwooleTW\Http\Transformers\Request now returns the real path of the file, and then on line 196 it compares it against public path which does not match, returns false and hence will not serve the static file.

if (substr($fileName, 0, strlen($publicPath)) != $publicPath) {
            return false;
}

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions