Should JSON marshal and unmarshal functions be moved to Dasgo? #54
Closed
switchupcb
started this conversation in
Polls
Replies: 3 comments
-
This poll will be closed upon the introduction of the Discord API |
Beta Was this translation helpful? Give feedback.
0 replies
-
The poll has been closed early to anticipate the update schedule: The result is yes, JSON marshal and unmarshal functions will be moved to Dasgo. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Operation aborted during implementation: Too many API Wrapper specific details in JSON marshal and marshal function implementations. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
With the introduction of the
Flags
type (to address #53), an inconsistency is made apparent with regards to the decoupling ofdasgo
types to their respectiveMarshalJSON
andUnmarshalJSON
functions. This inconsistency can be addressed by moving the code defined in the following files todasgo
.This change would move the responsibility of JSON marshal and unmarshal functions to
dasgo
. In doing so, these functions would be maintained by the maintainers ofdasgo
which is reviewed by multiple Go Discord API Wrappers. This reduces the overhead of maintaining this code fromdisgo
maintainers todasgo
maintainers at the cost of standardization.All code from
dasgo
continues to be optional to use. However, it would be recommended— upon approval of this change — to stick to the function definitions defined bydasgo
. Such that the cost of standardization would be usingdasgo
JSON marshal and unmarshalerror
messages or decision topanic
, but nothing else.This change would NOT effect the performance of
disgo
.1 vote ·
Beta Was this translation helpful? Give feedback.
All reactions