Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up button variables #3870

Open
gfellerph opened this issue Nov 1, 2024 · 0 comments
Open

Clean up button variables #3870

gfellerph opened this issue Nov 1, 2024 · 0 comments
Labels
📦 styles Related to the @swisspost/design-system-styles package
Milestone
Maintenance III

Comments

@gfellerph
Copy link
Member

In packages/styles/src/variables/components/_button.scss, a lot of older variables are declared. Go through them and determine if:

  1. The variable is only used by the button component -> move the definition to src/components/button.scss
  2. The variable is used by another component -> redefine the variable for this component, component variables should not be cross-referenced
  3. The variable is used by other variable files -> redefine the variable for the components using it
  4. The variable is unused -> delete it

The goal is, to eventually get rid of the button variable file if at all possible.
@gfellerph gfellerph added the 📦 styles Related to the @swisspost/design-system-styles package label Nov 1, 2024
@gfellerph gfellerph added this to the Maintenance III milestone Nov 1, 2024
@gfellerph gfellerph mentioned this issue Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Status: 👀 Triage
Milestone
Maintenance III
Development

No branches or pull requests
1 participant
@gfellerph