Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[component]: Switch #3275

Open
6 of 7 tasks
Tracked by #3628
Cian77 opened this issue Jul 16, 2024 · 4 comments · May be fixed by #3965
Open
6 of 7 tasks
Tracked by #3628

[component]: Switch #3275

Cian77 opened this issue Jul 16, 2024 · 4 comments · May be fixed by #3965
Assignees
Labels
📦 styles Related to the @swisspost/design-system-styles package

Comments

@Cian77
Copy link

Cian77 commented Jul 16, 2024

Description

Create a HTML/CSS component using the current markup that implements as many features as possible from the new Design. Remove any dependencies on bootstrap for this component. This is done for backwards compatibility reasons. The current structure will eventually be deprecated. These styles will give us the necessary time to come up with a solid input component strategy.

Open issues:

Design:

  • New font
  • Spacing

Tokens:

  • Text

Design

https://www.figma.com/design/JIT5AdGYqv6bDRpfBPV8XR/Foundations-%26-Components-Next-Level?node-id=21-178

Tokens

  • Tokens for this component are ready

Tasks

💻 Tasks

  1. 2 of 3
    good first issue 📦 styles
    bashirkarimi
@Cian77 Cian77 added the 📦 components Related to the @swisspost/design-system-components package label Jul 16, 2024
@Cian77 Cian77 added this to the Components v2 milestone Jul 16, 2024
@gfellerph gfellerph changed the title Switch: [component]: Switch Jul 25, 2024
@gfellerph gfellerph added 📦 styles Related to the @swisspost/design-system-styles package and removed 📦 components Related to the @swisspost/design-system-components package labels Jul 25, 2024
@Cian77
Copy link
Author

Cian77 commented Aug 12, 2024

Deleted Switch Group. In this component, we do not have an Error to show.

@gfellerph gfellerph added needs: discussion There is at least one topic in the pattern descussion meeting about the issue and removed needs: discussion There is at least one topic in the pattern descussion meeting about the issue labels Aug 14, 2024
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Aug 20, 2024
@gfellerph gfellerph moved this from 💻 Ready for development to 🔮 Tokens pending in Design System Production Board Aug 22, 2024
@schaertim schaertim self-assigned this Sep 11, 2024
@oliverschuerch
Copy link
Contributor

oliverschuerch commented Sep 17, 2024

@schaertim please assign this ticket to me or @gfellerph, as soon as you have implemented the component (as far as possible).
There are several tasks we need to do before we can finish this component:

  • Update focus style structure in Figma, so the focus element has a padding (as it will be interaged on other form controls as well) which we can use as a outline-offset afterwards.
  • Reqest some focus outline tokens like stroke-width, stroke-color and stroke-dasharray.

@Vandapanda
Copy link
Contributor

@schaertim Overworked the switch component so that it has a (sometimes invisible) border in every state. Implemented the new focus style, added tokens for Focus border and changed some token names for better understanding. Please let me know if you need something else

@gfellerph gfellerph modified the milestones: Design v2, Cargo Components Oct 1, 2024
@schaertim schaertim added the on hold Wait for something to be done, before continue working on this Issue label Oct 3, 2024
@oliverschuerch
Copy link
Contributor

@schaertim do you need anything from my side other than merging the newest tokens to main?

@oliverschuerch oliverschuerch removed their assignment Oct 9, 2024
@schaertim schaertim added on hold Wait for something to be done, before continue working on this Issue and removed on hold Wait for something to be done, before continue working on this Issue labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 styles Related to the @swisspost/design-system-styles package
Projects
Status: 🤬 Dev in review
5 participants