Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish release and develop changes. Updates logback configuration #3

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

Lesrac
Copy link
Contributor

@Lesrac Lesrac commented Jun 26, 2024

No description provided.

@Lesrac Lesrac requested a review from rsteppac June 26, 2024 11:53
@@ -184,3 +185,30 @@ project.afterEvaluate {
}
}
}

tasks.register("publishVersion") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the task actually doing? Could it be that the task logic is missing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It triggers the MavenPublication "bootJava" (see usage in workflows/publish.yml). But yeah it's not really obvious that the "dependsOn" trigger that one

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the rational behind logging JSON encoded logs to stdout and pipe separated logs to a file? Would it not be better to use the same human friendly pipe separated format for both appenders and rather document how to use a custom logback.xml with the client with an example of the JSON encoder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that the stdout is used to be processed by another service (like Azure Application Insights or Splunk Universal Forwarder) and therefore the JSON encoding would be the preferred way. I wouldn't know another reason outside of development that would prefer human friendly readable stdout logs

@Lesrac Lesrac merged commit 0f0f180 into develop Jul 1, 2024
4 checks passed
@Lesrac Lesrac deleted the feature/release-pipeline branch July 1, 2024 06:48
Lesrac added a commit that referenced this pull request Oct 30, 2024
publish release and develop changes. Updates logback configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants