Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship non-threads and threads SDKs as a single SDK #5590

Open
kateinoigakukun opened this issue Aug 30, 2024 · 5 comments
Open

Ship non-threads and threads SDKs as a single SDK #5590

kateinoigakukun opened this issue Aug 30, 2024 · 5 comments

Comments

@kateinoigakukun
Copy link
Member

SwiftPM does not allow multiple targets within a single Swift SDK for now. There is no reason for the restriction and it forces us to distribute two SDKs for wasm32-unknown-wasip1-threads and wasm32-unknown-wasi.

@kateinoigakukun kateinoigakukun converted this from a draft issue Aug 30, 2024
@ephemer
Copy link

ephemer commented Dec 5, 2024

@finagolfin seems to have implemented multiple targets within the Android SDK, I'm curious whether that approach is accessible here?

@finagolfin
Copy link

Yeah, who says it's not allowed? The Musl static SDK bundle also supports multiple targets.

@kateinoigakukun
Copy link
Member Author

The problem is even the format allows multiple targets, tools cannot uniquely select one of them when multiple SDK bundles containing multiple targets. See swiftlang/swift-package-manager#7973

@finagolfin
Copy link

OK, sure, that's a known bug, but it will only affect you if you're using the same target triple for threads and non-threads? Otherwise, why would you need multiple wasm SDK bundles anyway?

@kateinoigakukun
Copy link
Member Author

it will only affect you if you're using the same target triple for threads and non-threads?

It could also be a problem if we are installing multiple versions of Wasm SDKs. We are frequently updating our SDK, so different branches in some code base can use different SDKs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

3 participants