Fix failing cochran (#12)

* add failing cochran test

* if all values are same, cochran should return no outliers

* bump version

Author: aozisik

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "labkar-algorithms",
-  "version": "5.3.4",
+  "version": "5.3.5",
   "description": "Labkar Algorithms",
   "main": "dist/lib.js",
   "author": "ODTÜ PAL",

package.json

@@ -7,12 +7,24 @@ type CochranOptions = {
   alpha: number;
   originalIndexes?: number[];
   outlierIndexes?: number[];
-}
+};
 
 export function Cochran(
   values: Array<number[]>,
   options: CochranOptions = { alpha: 0.05 }
 ): CochranResult | null {
+  // Early return if all values are identical
+  const allIdentical = values.every(
+    (sample) =>
+      sample.every((value) => value === sample[0]) && sample[0] === values[0][0]
+  );
+
+  if (allIdentical) {
+    return {
+      outlierIndexes: [],
+      hasOutliers: false,
+    };
+  }
 
   // Keep track of original indexes of values at the beginning
   // When we return indexes of outliers, this will be useful.
@@ -67,7 +79,7 @@ export function Cochran(
     {
       alpha: options.alpha,
       originalIndexes,
-      outlierIndexes
+      outlierIndexes,
     }
-  )
+  );
 }

src/algorithms/cochran.ts

@@ -63,7 +63,7 @@ describe('Algorithms', () => {
     // expect(output.hampel).toBeCloseTo(44.722, 3);
   });
 
-  it.skip('Q/Hampel Method (samples with no variance)', () => {
+  it('Q/Hampel Method (samples with no variance)', () => {
     const samples = [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1];
 
     const q = Q(samples);

tests/algorithms.test.ts

@@ -58,7 +58,6 @@ describe('Cochran Algorithm', () => {
   });
 
   it('Repeats test until there are no outliers', () => {
-
     const samples = [
       [0.135, 0.194], // index=0 = outlier
       [0.187, 0.189],
@@ -70,10 +69,40 @@ describe('Cochran Algorithm', () => {
       [0.177, 0.186],
       [0.179, 0.187],
       [0.188, 0.196],
-    ]
+    ];
 
     const output = Cochran(samples, { alpha: 0.01 });
     expect(output?.outlierIndexes).toContain(0);
     expect(output?.outlierIndexes).toContain(5);
-  })
+  });
+
+  it('Cochran Algorithm Test (New Values)', () => {
+    const samples = [
+      [1, 1],
+      [1, 1],
+      [1, 1],
+      [1, 1],
+      [1, 1],
+      [1, 1],
+      [1, 1],
+    ];
+
+    const output = Cochran(samples);
+    expect(output?.hasOutliers).toBe(false); // Adjust the expectation based on your algorithm's behavior
+  });
+
+  it('Cochran Algorithm Test (New Values)', () => {
+    const samples = [
+      [1, 1],
+      [1, 1],
+      [1, 1],
+      [1, 1],
+      [1, 1],
+      [1, 1],
+      [1, 1],
+    ];
+
+    const output = Cochran(samples);
+    expect(output?.hasOutliers).toBe(false); // Adjust the expectation based on your algorithm's behavior
+  });
 });