Add PR comments

Author: bkhouri

Sources/_InternalTestSupport/misc.swift

@@ -42,6 +42,17 @@ import enum TSCUtility.Git
 public let isInCiEnvironment = ProcessInfo.processInfo.environment["SWIFTCI_USE_LOCAL_DEPS"] != nil
 public let isSelfHostedCiEnvironment = ProcessInfo.processInfo.environment["SWIFTCI_IS_SELF_HOSTED"] != nil
 
+public let isRealSigningIdentyEcLabelEnvVarSet =
+    ProcessInfo.processInfo.environment["REAL_SIGNING_IDENTITY_EC_LABEL"] != nil
+
+public let isRealSigningIdentitTestDefined = {
+    #if ENABLE_REAL_SIGNING_IDENTITY_TEST
+        return true
+    #else
+        return false
+    #endif
+}()
+
 /// Test helper utility for executing a block with a temporary directory.
 public func testWithTemporaryDirectory(
     function: StaticString = #function,

Tests/PackageSigningTests/FilePackageSigningEntityStorageTests.swift

@@ -135,17 +135,6 @@ struct FilePackageSigningEntityStorageTests {
             }
             return true
         }
-        // await XCTAssertAsyncThrowsError(try storage.put(
-        //     package: package,
-        //     version: version,
-        //     signingEntity: appleseed,
-        //     origin: .registry(URL("http://foo.com"))
-        // )) { error in
-        //     guard case PackageSigningEntityStorageError.conflict = error else {
-        //         Issue.record("Expected PackageSigningEntityStorageError.conflict, got \(error)")
-        //         return
-        //     }
-        // }
     }
 
     @Test
@@ -208,17 +197,6 @@ struct FilePackageSigningEntityStorageTests {
             }
             return true
         }
-        // await XCTAssertAsyncThrowsError(try storage.put(
-        //     package: package,
-        //     version: version,
-        //     signingEntity: appleseed,
-        //     origin: .registry(URL("http://bar.com")) // origin is different and should be added
-        // )) { error in
-        //     guard case PackageSigningEntityStorageError.unrecognizedSigningEntity = error else {
-        //         Issue.record("Expected PackageSigningEntityStorageError.unrecognizedSigningEntity but got \(error)")
-        //         return
-        //     }
-        // }
     }
 
     @Test
@@ -302,17 +280,6 @@ struct FilePackageSigningEntityStorageTests {
             }
             return true
         }
-        // await XCTAssertAsyncThrowsError(try storage.add(
-        //     package: package,
-        //     version: version,
-        //     signingEntity: appleseed,
-        //     origin: .registry(URL("http://bar.com"))
-        // )) { error in
-        //     guard case PackageSigningEntityStorageError.unrecognizedSigningEntity = error else {
-        //         Issue.record("Expected PackageSigningEntityStorageError.unrecognizedSigningEntity but got \(error)")
-        //         return
-        //     }
-        // }
     }
 
     @Test
@@ -479,17 +446,6 @@ struct FilePackageSigningEntityStorageTests {
             }
             return true
         }
-        // await XCTAsserttAsyncThrowsError(try storage.changeSigningEntityForAllVersions(
-        //     package: package,
-        //     version: Version("1.5.0"),
-        //     signingEntity: appleseed,
-        //     origin: .registry(URL("http://bar.com"))
-        // )) { error in
-        //     guard case PackageSigningEntityStorageError.unrecognizedSigningEntity = error else {
-        //         Issue.record("Expected PackageSigningEntityStorageError.unrecognizedSigningEntity but got \(error)")
-        //         return
-        //     }
-        // }
     }
 }