(123636178) Resolving symlinks can remove prefix from path

Author: jmschonfeld

Sources/FoundationEssentials/String/String+Path.swift

@@ -361,19 +361,18 @@ extension String {
             return nil
         }
 
+        let length = Int(buffer.fullPathAttr.attr_length) // Includes null byte
         return withUnsafePointer(to: buffer.fullPathBuf) { pathPtr in
-            let start = UnsafeRawPointer(pathPtr).advanced(by: Int(buffer.fullPathAttr.attr_dataoffset))
-            let length = Int(buffer.fullPathAttr.attr_length) // Includes null byte
-            return start.withMemoryRebound(to: CChar.self, capacity: length) { ccharPtr in
-                return String(cString: ccharPtr)
+            pathPtr.withMemoryRebound(to: CChar.self, capacity: length) { ccharPtr in
+                String(cString: ccharPtr)
             }
         }
         #else
         return nil
         #endif
     }
 
-    private func _resolvingSymlinksInPath() -> String? {
+    func _resolvingSymlinksInPath() -> String? {
         guard !isEmpty else { return nil }
         return self.withFileSystemRepresentation { fsPtr -> String? in
             guard let fsPtr else { return nil }

Tests/FoundationEssentialsTests/FileManager/FileManagerTests.swift

@@ -566,4 +566,15 @@ final class FileManagerTests : XCTestCase {
         throw XCTSkip("This test is not applicable to this platform")
         #endif
     }
+    
+    func testResolveSymlinksViaGetAttrList() throws {
+        try FileManagerPlayground {
+            "destination"
+        }.test {
+            try $0.createSymbolicLink(atPath: "link", withDestinationPath: "destination")
+            let absolutePath = $0.currentDirectoryPath.appendingPathComponent("link")
+            let resolved = absolutePath._resolvingSymlinksInPath() // Call internal function to avoid path standardization
+            XCTAssertEqual(resolved, $0.currentDirectoryPath.appendingPathComponent("destination"))
+        }
+    }
 }