Skip to content

Commit fa256db

Browse files
authored
revert "Prevent NavigatorCard from re-render when fetching data" #865 (#907) rdar://130779044
revert "Prevent NavigatorCard from re-render when fetching data" #865 (#907) rdar://130779044
1 parent a0186a1 commit fa256db

File tree

2 files changed

+2
-11
lines changed

2 files changed

+2
-11
lines changed

src/components/Navigator.vue

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
class="navigator"
1515
>
1616
<NavigatorCard
17-
v-show="!isFetching"
17+
v-if="!isFetching"
1818
v-bind="technologyProps"
1919
:type="type"
2020
:children="flatChildren"
@@ -36,7 +36,7 @@
3636
</NavigatorCard>
3737
<LoadingNavigatorCard
3838
@close="$emit('close')"
39-
v-if="isFetching"
39+
v-else
4040
/>
4141
<div aria-live="polite" class="visuallyhidden">
4242
{{ $t('navigator.navigator-is', {

tests/unit/components/Navigator.spec.js

-9
Original file line numberDiff line numberDiff line change
@@ -126,15 +126,6 @@ describe('Navigator', () => {
126126
expect(wrapper.find(LoadingNavigatorCard).exists()).toBe(false);
127127
});
128128

129-
it('adds display:none to NavigatorCard when navigator is loading', () => {
130-
const wrapper = createWrapper({
131-
propsData: {
132-
isFetching: true,
133-
},
134-
});
135-
expect(wrapper.find(NavigatorCard).attributes('style')).toContain('display: none');
136-
});
137-
138129
it('renders an aria live that tells VO users when navigator is ready', () => {
139130
const wrapper = createWrapper();
140131
expect(wrapper.find('[aria-live="polite"]').exists()).toBe(true);

0 commit comments

Comments
 (0)