Skip to content

Commit 00396f0

Browse files
committed
Delete unnecessary nav-dark mode in HierarchyCollapsedItems
1 parent e4a7677 commit 00396f0

File tree

3 files changed

+4
-19
lines changed

3 files changed

+4
-19
lines changed

src/components/DocumentationTopic/Hero/HierarchyCollapsedItems.vue

-15
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ $border-width: 1px;
100100
// Values specified in rgba due to alpha transparency used in the background
101101
// of the nav area, so they are represented as clear overlays here
102102
$toggle-bg-color: var(--color-nav-hierarchy-collapse-background);
103-
$toggle-bg-color-dark: var(--color-nav-dark-hierarchy-collapse-background);
104103
$toggle-bg-color-hover: var(--color-nav-hierarchy-collapse-background-hover);
105104
$toggle-border-color: var(--color-nav-hierarchy-collapse-borders);
106105
$toggle-border-color-hover: var(--color-nav-hierarchy-collapse-borders-hover);
@@ -111,9 +110,7 @@ $toggle-width: rem(36px);
111110
// Values specified here are opaque versions of the dropdown colors so that
112111
// they match (without using alpha)
113112
$dropdown-bg-color: $toggle-bg-color;
114-
$dropdown-bg-color-dark: $toggle-bg-color-dark;
115113
$dropdown-border-color: var(--color-nav-hierarchy-collapse-borders);
116-
$dropdown-border-color-dark: var(--color-nav-dark-hierarchy-collapse-borders);
117114
$dropdown-transition-duration: 250ms;
118115
$hierarchy-dropdown-border-width: 0px !default;
119116
$hierarchy-dropdown-box-shadow: 0 1px 4px -1px var(--color-figure-gray-secondary) !default;
@@ -197,10 +194,6 @@ $dropdown-vertical-offset: rem(7px);
197194
position: absolute;
198195
z-index: 42;
199196
top: calc(100% + #{$dropdown-vertical-offset});
200-
@include nav-dark() {
201-
background: $dropdown-bg-color-dark;
202-
border-color: $dropdown-border-color-dark;
203-
}
204197

205198
&.collapsed {
206199
opacity: 0;
@@ -238,10 +231,6 @@ $dropdown-vertical-offset: rem(7px);
238231
left: $tail-offset;
239232
position: absolute;
240233
top: rem($border-width) - $tail-width;
241-
242-
@include nav-dark() {
243-
border-bottom-color: $dropdown-bg-color-dark;
244-
}
245234
}
246235
}
247236

@@ -250,10 +239,6 @@ $dropdown-vertical-offset: rem(7px);
250239
border-top-style: $border-style;
251240
border-top-width: $border-width;
252241

253-
@include nav-dark() {
254-
border-top-color: $dropdown-border-color-dark;
255-
}
256-
257242
&:first-child {
258243
border-top: none;
259244
}

src/styles/core/colors/_dark.scss

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@
4444
--color-nav-color: var(--color-nav-dark-color);
4545
--color-nav-current-link: var(--color-nav-dark-current-link);
4646
--color-nav-expanded: var(--color-nav-dark-expanded);
47-
--color-nav-hierarchy-collapse-background: var(--color-nav-dark-hierarchy-collapse-background);
48-
--color-nav-hierarchy-collapse-borders: var(--color-nav-dark-hierarchy-collapse-borders);
47+
--color-nav-hierarchy-collapse-background: #{dark-color(fill-gray-tertiary)};
48+
--color-nav-hierarchy-collapse-borders: #{light-color(figure-gray-secondary)};
4949
--color-nav-hierarchy-collapse-background-hover: #{change-color(dark-color(fill-blue), $alpha: 0.5)};
5050
--color-nav-hierarchy-collapse-borders-hover: #{dark-color(figure-blue)};
5151
--color-nav-hierarchy-item-borders: var(--color-nav-dark-hierarchy-item-borders);

src/styles/core/colors/_light.scss

+2-2
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,9 @@
103103
--color-nav-current-link: #{change-color(light-color(figure-gray))};
104104
--color-nav-expanded: #{light-color(fill)};
105105
--color-nav-hierarchy-collapse-background: #{light-color(fill-gray-tertiary)};
106+
--color-nav-hierarchy-collapse-background-hover: #{change-color(light-color(fill-blue), $alpha: 0.05)};
106107
--color-nav-hierarchy-collapse-borders: #{dark-color(figure-gray-secondary)};
108+
--color-nav-hierarchy-collapse-borders-hover: #{light-color(figure-blue)};
107109
--color-nav-hierarchy-item-borders: #{dark-color(figure-gray-secondary)};
108110
--color-nav-keyline: #{change-color(light-color(figure-gray), $alpha: 0.2)};
109111
--color-nav-link-color: #{light-color(figure-gray)};
@@ -120,8 +122,6 @@
120122
--color-nav-dark-color: #{dark-color(figure-gray)};
121123
--color-nav-dark-current-link: #{change-color(dark-color(figure-gray))};
122124
--color-nav-dark-expanded: #{dark-color(fill-tertiary)};
123-
--color-nav-dark-hierarchy-collapse-background: #{dark-color(fill-gray-tertiary)};
124-
--color-nav-dark-hierarchy-collapse-borders: #{light-color(figure-gray-secondary)};
125125
--color-nav-dark-hierarchy-item-borders: #{dark-color(fill-gray-tertiary)};
126126
--color-nav-dark-keyline: #{change-color(dark-color(fill-gray-tertiary), $alpha: 0.95)};
127127
--color-nav-dark-link-color: #{dark-color(figure-gray)};

0 commit comments

Comments
 (0)