Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClangLanguageService should decide whether to withhold fallback diagnostics based on previous build settings not upcoming build settings #1761

Open
ahoppen opened this issue Oct 16, 2024 · 1 comment

Comments

@ahoppen
Copy link
Member

ahoppen commented Oct 16, 2024

ClangLanguageService.publishDiagnostics gets the build settings for the file to determine whether it should withhold them because they are fallback settings. But really, what matters here is whether it had build settings at the point when the last update was sent, not whether build settings can be retrieved after the clangd sent a publish diagnostics notification. To do this, we probably need to keep track of which files have proper build settings and which ones have fallback build settings in ClangLanguageService.

@ahoppen
Copy link
Member Author

ahoppen commented Oct 16, 2024

Synced to Apple’s issue tracker as rdar://138006475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant