Use fallback build settings if build system doesn’t provide build settings within a timeout #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
…tings within a timeout When we receive build settings after hitting the timeout, we call `fileBuildSettingsChanged` on the delegate, which should cause the document to get re-opened in sourcekitd and diagnostics to get refreshed. rdar://136332685 Fixes swiftlang#1693
ahoppen
force-pushed
the
build-settings-timeout
branch
from
6c98312
to
5bae73f
Compare
|
@swift-ci Please test |
|
Ran the test suite 20 times locally as-is and 20 times with a 1s delay before getting build settings from the build system. This should rule out any nondeterministic failures. |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we receive build settings after hitting the timeout, we call
fileBuildSettingsChangedon the delegate, which should cause the document to get re-opened in sourcekitd and diagnostics to get refreshed.rdar://136332685
Fixes #1693