Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When running tests, raise in XCTFail if logger.fault is called #1669

Open
ahoppen opened this issue Sep 14, 2024 · 1 comment · May be fixed by #1703
Open

When running tests, raise in XCTFail if logger.fault is called #1669

ahoppen opened this issue Sep 14, 2024 · 1 comment · May be fixed by #1703

Comments

@ahoppen
Copy link
Member

ahoppen commented Sep 14, 2024

logger.fault indicates that there was an internal error in SourceKit-LSP. We should ensure that we don’t hit any situation that causes a logger.fault while running tests by raising an XCTFail if logger.fault is called in NonDarwinLogger (which is the logger that we’re using in Swift CI).
@ahoppen
Copy link
Member Author

ahoppen commented Sep 14, 2024

Synced to Apple’s issue tracker as rdar://136014548

ahoppen added a commit to ahoppen/sourcekit-lsp that referenced this issue Sep 21, 2024
@ahoppen
When running tests, raise in XCTFail if logger.fault is called
e41c2f0 
`logger.fault` indicates that there was an internal error in SourceKit-LSP. We should ensure that we don’t hit any situation that causes a `logger.fault` while running tests by raising an `XCTFail` if `logger.fault` is called in `NonDarwinLogger` (which is the logger that we’re using in Swift CI).

rdar://136014548
Resolves swiftlang#1669
@ahoppen ahoppen linked a pull request Sep 21, 2024 that will close this issue
Open
ahoppen added a commit to ahoppen/sourcekit-lsp that referenced this issue Sep 21, 2024
@ahoppen
When running tests, raise in XCTFail if logger.fault is called
a799e50 
`logger.fault` indicates that there was an internal error in SourceKit-LSP. We should ensure that we don’t hit any situation that causes a `logger.fault` while running tests by raising an `XCTFail` if `logger.fault` is called in `NonDarwinLogger` (which is the logger that we’re using in Swift CI).

rdar://136014548
Resolves swiftlang#1669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

When running tests, raise in XCTFail if logger.fault is called 🚥 #1701 ahoppen/sourcekit-lsp
1 participant
@ahoppen