Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with Python 3.10 #43

Closed
slhck opened this issue Mar 2, 2022 · 4 comments
Closed

Does not work with Python 3.10 #43

slhck opened this issue Mar 2, 2022 · 4 comments

Comments

@slhck
Copy link

slhck commented Mar 2, 2022

I am getting this error using v1.3.3 of this package:

    from p_tqdm import p_imap
  File "/Users/werner/.pyenv/versions/3.10.0/lib/python3.10/site-packages/p_tqdm/__init__.py", line 1, in <module>
    from p_tqdm.p_tqdm import p_map, p_imap, p_umap, p_uimap, t_map, t_imap
  File "/Users/werner/.pyenv/versions/3.10.0/lib/python3.10/site-packages/p_tqdm/p_tqdm.py", line 11, in <module>
    from collections import Sized
ImportError: cannot import name 'Sized' from 'collections' (/Users/werner/.pyenv/versions/3.10.0/lib/python3.10/collections/__init__.py)

The import should come from collections.abc instead of collections.

@slhck
Copy link
Author

slhck commented Mar 2, 2022

Ah, I see this has been addressed here: #42

Is this project still alive? I see there hasn't been much activity …

@bridgerdier
Copy link

It appears the tests use a package (nose) with a similar issue (also an import from collections instead of collections.abc). Perhaps this is stopping a release?

Would be really nice to have an updated version appear on PyPI.

@swansonk14
Copy link
Owner

Hi @slhck and @bridgerdier,

I apologize for the issues! I have not been actively maintaining p_tqdm. I merged in a few PRs that fix this issue and published a new release (https://github.com/swansonk14/p_tqdm/releases/tag/v_1.4.0), which I also pushed to PyPI. So this issue should be fixed now.

Thank you for bringing up this issue and for using p_tqdm!

Best,
Kyle

@slhck
Copy link
Author

slhck commented Aug 27, 2022

Thanks! Still a very happy user of this package 😊

Hope you will find some time to make the occasional release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants