-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commented the intro information so it can be reused next year #390
base: development
Are you sure you want to change the base?
Conversation
Perhaps the title says it all. This is a really simple workflow, and it's open for any changes or adjustments
* added instagram logo * added doorgeefluik url's
Could we do this via contentful perhaps? |
Id favour doing to it via contentful too, or let it be done automatically based on the date in the year |
let's look at it in 2 hours! |
aee4a36
to
51adc6a
Compare
Now that I've figured out how to access contentful, it seems that we could easily add a checkbox for the intro information that would enable or disable it. And since publishing changes in contentful (should) cause a re-deploy, I definitely think this is the best solution. |
Then I would be highly in favor of making this depend on contentfull I suggest we rename this PR and do that instead |
Unpublishing the intro information currently results in a build error, so i've added a fix so that unpublishing just ignores the intro information and patches the rest of the home page layout. Love to have a quick review on this from someone else, so we can merge this. |
Comment out the important introduction related components, so they can be reused next year, but are not used currently.
It ain't pretty, but it works :)