Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding eslint for code inspection #112

Open
cdfa opened this issue Mar 1, 2019 · 1 comment
Open

Adding eslint for code inspection #112

cdfa opened this issue Mar 1, 2019 · 1 comment
Labels
enhancement Proposes (changes to) a feature

Comments

@cdfa
Copy link
Contributor

cdfa commented Mar 1, 2019

I think we should consider adding eslint to the development workflow, since it provides value code inspection about possible bugs and misuse of packages, like React hooks with the new eslint-plugin-react-hooks (I just updated dependencies and noted this, so that's why I'm writing this now).

NOTE: There are ways to disable eslint's formatting warnings to be handled by prettier.

@cdfa cdfa added the discussion label Mar 1, 2019
@Riscky Riscky added enhancement Proposes (changes to) a feature and removed discussion labels May 8, 2020
@Riscky
Copy link
Member

Riscky commented May 8, 2020

I'm defs in favour, the more we check before deploying the better

@Riscky Riscky linked a pull request May 15, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Proposes (changes to) a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants