From 4a03d37320cf9281f6adbbd431644a21154ea853 Mon Sep 17 00:00:00 2001
From: Sean DeNigris <code@clipperadams.com>
Date: Tue, 13 Aug 2024 22:01:13 -0400
Subject: [PATCH] [Enh]: MA Two Stage Importer - Hooks to Fix Stream &
 Record...

Before passing along to next step
---
 .../MACSVTwoStageImporter.class.st            | 24 +++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/repository/Neo-CSV-Magritte/MACSVTwoStageImporter.class.st b/repository/Neo-CSV-Magritte/MACSVTwoStageImporter.class.st
index 474d4cd..38452a9 100644
--- a/repository/Neo-CSV-Magritte/MACSVTwoStageImporter.class.st
+++ b/repository/Neo-CSV-Magritte/MACSVTwoStageImporter.class.st
@@ -56,6 +56,7 @@ MACSVTwoStageImporter >> convertToDomainObjects: aCollectionOfDictionaries [
 			(self selectBlock value: rowDict)
 				ifTrue: [ 
 					result := self domainObjectFromDictionary: rowDict.
+					self prepareRecord: result.
 					col add: result ].
 			col ]
 ]
@@ -70,8 +71,9 @@ MACSVTwoStageImporter >> domainObjectFromDictionary: aDictionary [
 
 { #category : #accessing }
 MACSVTwoStageImporter >> importStream: aStream [
-	| rows |
-	self configureReaderFor: aStream.
+	| rows preparedStream |
+	preparedStream := self prepareStream: aStream.
+	self configureReaderFor: preparedStream.
 	rows := self reader upToEnd.
 	^ self convertToDomainObjects: rows
 ]
@@ -136,14 +138,28 @@ MACSVTwoStageImporter >> initializeDomainObject: anObject fromRecord: aDictionar
 	^ anObject
 ]
 
+{ #category : #accessing }
+MACSVTwoStageImporter >> prepareRecord: aDomainObject [
+	"Override this to fix input problems which are easier to fix utilizing real accessors and domain objects instead of in the preprocessor where you have dictionary keys and strings"
+]
+
+{ #category : #accessing }
+MACSVTwoStageImporter >> prepareStream: aStream [
+	"Override me e.g. if the input is not proper CSV. One might remove a standard number of header or footer lines, handle blank columns, etc"
+
+	^ aStream
+]
+
 { #category : #accessing }
 MACSVTwoStageImporter >> preprocessor [
 	^ preprocessor ifNil: [ #yourself ]
 ]
 
 { #category : #accessing }
-MACSVTwoStageImporter >> preprocessor: anObject [
-	preprocessor := anObject
+MACSVTwoStageImporter >> preprocessor: aValuable [
+	"Consider #prepareObject: first because it is generally easier to fix the record after initialization because we have real accessors and domain objects e.g. aDate instead of aDateString"
+
+	preprocessor := aValuable
 ]
 
 { #category : #accessing }