Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly remove navigation callbacks when returning function in onNavigate #13241

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Elia872
Copy link
Contributor

@Elia872 Elia872 commented Dec 25, 2024

closes #13240

the callbacks of afterNavigate do in fact get removed, just from the wrong array.

here after_navigate_callbacks gets re-assigned a new array, but here the splice() is done on an old reference.

to fix this i switched to a Set, and also changed to const to warn any future change. Sets keep the insertion order.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Dec 25, 2024

🦋 Changeset detected

Latest commit: 2c5f5fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino
Copy link
Member

I've tested it and LGTM but maybe someone else can take a second look as I'm unsure about the Array to Set changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

afterNavigate callbacks do not get removed when returning a function in onNavigate
3 participants