Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow for dynamic asynchronously rerouting #13186

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

nikosgram
Copy link

The Problem

The current SvelteKit Reroute functionality doesn't support dynamic rerouting for localization where settings are stored in a database.

The solution?

Modify the Reroute function to return MaybePromise<void | string> and update its implementation in server/response.js and client/client.js.

Usage

import type { Reroute } from '@sveltejs/kit';

export const reroute: Reroute = async ({ url }) => {
    if (url.pathname.startsWith('/api')) {
        return;
    }
    
    const response = await fetch(url.protocol + '//' + url.host + '/api/locales');

    const locales = await response.json(); // as Type[];

    // write re-routing logic here
};

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: 470102b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13186-svelte.vercel.app/

this is an automated message

@nikosgram nikosgram changed the title feat(reroute): Allow for dynamic asynchronously rerouting #13176 fix: Allow for dynamic asynchronously rerouting #13176 Dec 17, 2024
@nikosgram nikosgram changed the title fix: Allow for dynamic asynchronously rerouting #13176 fix: Allow for dynamic asynchronously rerouting Dec 17, 2024
@nikosgram
Copy link
Author

Relevant Issue: #13176

@nikosgram nikosgram changed the title fix: Allow for dynamic asynchronously rerouting feat: Allow for dynamic asynchronously rerouting Dec 17, 2024
@eltigerchino eltigerchino linked an issue Dec 18, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(reroute): Allow for dynamic asynchronously rerouting
2 participants