Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt for installing dependencies in new projects #128

Closed
benmccann opened this issue Oct 15, 2024 · 6 comments · Fixed by #164
Closed

Prompt for installing dependencies in new projects #128

benmccann opened this issue Oct 15, 2024 · 6 comments · Fixed by #164

Comments

@benmccann
Copy link
Member

npx sv create myapp automatically installs dependencies and I'd prefer it not to

I'm using 0.5.2, which was just released with the latest code

@benmccann benmccann mentioned this issue Oct 15, 2024
24 tasks
@AdrianGonz97
Copy link
Member

I'm unable to reproduce this. is this occurring even when there's no lockfile?

@benmccann
Copy link
Member Author

ohh. It looks like I had a package-lock.json file present in the directory where I ran this. I don't know how I keep doing that 😝

Do we want it to prompt or do it automatically in that case?

@AdrianGonz97
Copy link
Member

AFAIK, we're not able to differentiate where package-manager-detector found the lockfile, all that we know is that it found one

@benmccann
Copy link
Member Author

We could probably add an option to package-manager-detector to check if we're in a monorepo. I'm a maintainer on it, so can help get it merged and released

@AdrianGonz97
Copy link
Member

i won't lie, this is turning out to be more of a headache than it might be worth 😅

how about we go back to just asking what PM they want to use to install (we can still detect and have what we detect be their default option), rather than inferring it?

@benmccann
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants