Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wstaeblein repos #494

Closed
wants to merge 2 commits into from
Closed

Conversation

wstaeblein
Copy link

No description provided.

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for sveltesociety-preview ready!

Name Link
🔨 Latest commit fe45787
🔍 Latest deploy log https://app.netlify.com/sites/sveltesociety-preview/deploys/657cebe8353427000880c583
😎 Deploy Preview https://deploy-preview-494--sveltesociety-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MacFJA
Copy link
Collaborator

MacFJA commented Nov 19, 2023

Your PR have formatting issue.

Can you run pnpm run format to solve them?


Your PR is also in conflict as another PR was merged before yours, so if you can rebase it, it would be great.

@MacFJA MacFJA added the need rebase The PR need to be rebased label Nov 19, 2023
@lachlancollins lachlancollins removed the need rebase The PR need to be rebased label Dec 16, 2023
@MacFJA MacFJA added the need formatting The PR need to be formatted label Dec 16, 2023
@lachlancollins lachlancollins changed the title Update components.json Add wstaeblein repos Dec 18, 2023
@lachlancollins
Copy link
Collaborator

Hi @wstaeblein , thanks for your submissions! Unfortunately, the components.json file requires packages to be published on NPM, since we obtain metadata about the package from here. I understand these are simple components, however it also isn't straight-forward for a user to find the right code they need to copy into their own project.

If you would like to publish your package, you can use this template I created as an example structure. Let me know if I can do anything to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need formatting The PR need to be formatted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants