Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpResponseException have internal accessibility #13

Closed
Tasteful opened this issue Nov 29, 2021 · 1 comment
Closed

HttpResponseException have internal accessibility #13

Tasteful opened this issue Nov 29, 2021 · 1 comment
Assignees
@lounge
Labels
enhancement New feature or request

Comments

@Tasteful
Copy link
Contributor

The HttpResponseException have accessibility internal, this make it hard to catch the exception because we need to catch on Exceptoion and then use reflection to get the correct result back.

Can the HttpResponseException be changed to public accessibility?

svea-sdk-dotnet/src/Svea.WebPay.SDK/Exceptions/HttpResponseException.cs

Line 6 in ff22ee3

internal class HttpResponseException : Exception

@lounge lounge added the enhancement New feature or request label Nov 29, 2021
@lounge lounge self-assigned this Nov 29, 2021
@lounge
Copy link
Collaborator

lounge commented Nov 29, 2021

@Tasteful Fixed in release 2.1.1

@lounge lounge closed this as completed Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lounge lounge

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tasteful @lounge