Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with merge_mctal #32

Open
makeclean opened this issue Sep 16, 2013 · 3 comments
Open

Issue with merge_mctal #32

makeclean opened this issue Sep 16, 2013 · 3 comments
Assignees

Comments

@makeclean
Copy link
Contributor

I've discovered an issue with merge_mctal regarding collapsing, if we collapse two mcnp produced mctal files (eg mc1 and mc2), then we get a file which looks an awful lot like a mctal file. Which is good.

However, if we have 4 mtctal files mc1,mc2,mc3, and mc4, then if no matter how we combine these four files, eg

 mc1+mc2 => comb1
 mc3+mc4 => comb2
 comb2+comb1 => mc5

However, I cannot run merge_mctal on comb1 and comb2, it fails with an error when reading these files, suggesting that the format is not quite right.

  Error Reading comb1.: ('invalid literal for float(): 1.00000e-07s',)

I can send you the problem files if you want?

@ghost ghost assigned zwelchWI Sep 16, 2013
@gonuke
Copy link
Member

gonuke commented Sep 16, 2013

Add a failing test to the repo? better with small test files that fail.

@makeclean
Copy link
Contributor Author

Wrong SHA! 33491cb

@zwelchWI
Copy link
Contributor

There was an extra 's' in one of the write commands, it should be fixed
now. I tested the files you posted and the comb files now combine
properly.

Zach

On Mon Sep 16 16:28:15 2013, Andrew Davis wrote:

Wrong SHA! 33491cb
33491cb


Reply to this email directly or view it on GitHub
#32 (comment).

Zach Welch
Graduate Student
Dept of Computer Sciences
University of Wisconsin - Madison

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants