Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support validating approvers before applying #2228

Open
suzuki-shunsuke opened this issue Jan 10, 2025 · 0 comments
Open

Support validating approvers before applying #2228

suzuki-shunsuke opened this issue Jan 10, 2025 · 0 comments
Labels
enhancement New feature or request security

Comments

@suzuki-shunsuke
Copy link
Owner

Feature Overview

This issue proposes the feature to validate approvers before running terraform apply.
If no one other than pr's commit authors doesn't approve the pr, tfaction fails.

Why is the feature needed?

This feature needs to follow the policy All changes must be reviewed.
Even if we configure branch protection rules and branch rule set properly, people can violate this policy:

  • People can add commits to prs created by bots (GitHub Apps) and approve themselves
    • follow up prs
    • Renovate
  • People can add commits to prs created by others and approve themselves
    • Malicious people can abuse stale prs

Example Code

tfaction-root.yaml

validate_approvers: true

Note

No response

@suzuki-shunsuke suzuki-shunsuke added enhancement New feature or request security labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security
Projects
None yet
Development

No branches or pull requests

1 participant